1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
|
// Copyright 2025 syzkaller project authors. All rights reserved.
// Use of this source code is governed by Apache 2 LICENSE that can be found in the LICENSE file.
package service
import (
"bytes"
"context"
"fmt"
"time"
"github.com/google/syzkaller/syz-cluster/pkg/api"
"github.com/google/syzkaller/syz-cluster/pkg/app"
"github.com/google/syzkaller/syz-cluster/pkg/blob"
"github.com/google/syzkaller/syz-cluster/pkg/db"
"github.com/google/uuid"
)
type FindingService struct {
findingRepo *db.FindingRepository
sessionTestRepo *db.SessionTestRepository
buildRepo *db.BuildRepository
urls *api.URLGenerator
blobStorage blob.Storage
}
func NewFindingService(env *app.AppEnvironment) *FindingService {
return &FindingService{
findingRepo: db.NewFindingRepository(env.Spanner),
blobStorage: env.BlobStorage,
urls: env.URLs,
buildRepo: db.NewBuildRepository(env.Spanner),
sessionTestRepo: db.NewSessionTestRepository(env.Spanner),
}
}
func (s *FindingService) Save(ctx context.Context, req *api.NewFinding) error {
return s.findingRepo.Store(ctx, &db.FindingID{
SessionID: req.SessionID,
TestName: req.TestName,
Title: req.Title,
}, func(session *db.Session, old *db.Finding) (*db.Finding, error) {
if !session.FinishedAt.IsNull() {
// We may have already sent a report, so the findings must stay as they are.
return nil, fmt.Errorf("session is already finished")
}
if old != nil && (old.CReproURI != "" || len(req.CRepro) == 0) {
// The existing finding already has a C reproducer, no reason to update.
return nil, nil
}
finding := &db.Finding{
ID: uuid.NewString(),
SessionID: req.SessionID,
TestName: req.TestName,
Title: req.Title,
}
// TODO: if it's not actually addded, these blobs will be orphaned.
err := s.saveAssets(finding, req)
if err != nil {
return nil, err
}
return finding, nil
})
}
func (s *FindingService) saveAssets(finding *db.Finding, req *api.NewFinding) error {
type saveAsset struct {
saveTo *string
value []byte
name string
}
for _, asset := range []saveAsset{
{&finding.LogURI, req.Log, "log"},
{&finding.ReportURI, req.Report, "report"},
{&finding.SyzReproURI, req.SyzRepro, "syz_repro"},
{&finding.SyzReproOptsURI, req.SyzReproOpts, "syz_repro_opts"},
{&finding.CReproURI, req.CRepro, "c_repro"},
} {
if len(asset.value) == 0 {
continue
}
var err error
*asset.saveTo, err = s.blobStorage.Write(bytes.NewReader(asset.value), "Finding", finding.ID, asset.name)
if err != nil {
return fmt.Errorf("failed to save %s: %w", asset.name, err)
}
}
return nil
}
func (s *FindingService) InvalidateSession(ctx context.Context, sessionID string) error {
findings, err := s.findingRepo.ListForSession(ctx, sessionID, 0)
if err != nil {
return err
}
for _, finding := range findings {
err := s.findingRepo.Update(ctx, finding.ID, func(finding *db.Finding) error {
finding.SetInvalidatedAt(time.Now())
return nil
})
if err != nil {
return fmt.Errorf("failed to update finding %s: %w", finding.ID, err)
}
}
return nil
}
func (s *FindingService) List(ctx context.Context, sessionID string, limit int) ([]*api.Finding, error) {
list, err := s.findingRepo.ListForSession(ctx, sessionID, limit)
if err != nil {
return nil, fmt.Errorf("failed to query the list: %w", err)
}
tests, err := s.sessionTestRepo.BySession(ctx, sessionID)
if err != nil {
return nil, fmt.Errorf("failed to query session tests: %w", err)
}
testPerName := map[string]*db.FullSessionTest{}
for _, test := range tests {
testPerName[test.TestName] = test
}
var ret []*api.Finding
for _, item := range list {
finding := &api.Finding{
Title: item.Title,
LogURL: s.urls.FindingLog(item.ID),
}
if item.SyzReproURI != "" {
finding.LinkSyzRepro = s.urls.FindingSyzRepro(item.ID)
}
if item.CReproURI != "" {
finding.LinkCRepro = s.urls.FindingCRepro(item.ID)
}
if !item.InvalidatedAt.IsNull() {
finding.Invalidated = true
}
build := testPerName[item.TestName].PatchedBuild
if build != nil {
finding.Build = makeBuildInfo(s.urls, build)
}
bytes, err := blob.ReadAllBytes(s.blobStorage, item.ReportURI)
if err != nil {
return nil, fmt.Errorf("failed to read the report: %w", err)
}
finding.Report = string(bytes)
ret = append(ret, finding)
}
return ret, nil
}
|
