1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
|
// Copyright 2023 syzkaller project authors. All rights reserved.
// Use of this source code is governed by Apache 2 LICENSE that can be found in the LICENSE file.
package lists
import (
"testing"
"github.com/google/syzkaller/pkg/subsystem"
"github.com/stretchr/testify/assert"
)
// nolint: lll
func TestLinuxUpstreamSubsystems(t *testing.T) {
list := subsystem.GetList("linux")
if list == nil {
t.Fatalf("the list is not registered")
}
group := subsystem.MakeExtractor(list)
// For now let's keep all the regression tests in this .go file, but if later
// it turns out there are just too many of them, we will need to store it in
// separate files.
tests := []struct {
name string
crashes []*subsystem.Crash
expect []string
}{
{
name: `a pure xfs bug`,
crashes: []*subsystem.Crash{
{
GuiltyPath: `fs/xfs/libxfs/xfs_btree.c`,
SyzRepro: []byte(`# https://syzkaller.appspot.com/bug?id=e2907149c69cbccae0842eb502b8af4f6fac52a0
# See https://goo.gl/kgGztJ for information about syzkaller reproducers.
#{"procs":1,"slowdown":1,"sandbox":"","sandbox_arg":0,"close_fds":false}
syz_mount_image$xfs(&(0x7f0000000100), &(0x7f0000009640)='./file2\x00', 0x200800, &(0x7f0000000240)=ANY=[], 0x1, 0x9712, &(0x7f0000009680)="$eJzs3Qm4pnPhuPH=")
`),
},
},
expect: []string{"xfs"},
},
{
name: `a seemingly vfs bug`,
crashes: []*subsystem.Crash{
{
GuiltyPath: `fs/namei.c`,
},
{
GuiltyPath: `fs/namei.c`,
SyzRepro: []byte(`# https://syzkaller.appspot.com/bug?id=cdaf5ed409125df023889aefe50b4cc4a41c0973
# See https://goo.gl/kgGztJ for information about syzkaller reproducers.
#{"threaded":true,"repeat":true,"procs":6,"slowdown":1,"sandbox":"","sandbox_arg":0,"close_fds":false,"ieee802154":true,"sysctl":true,"tmpdir":true,"segv":true}
syz_mount_image$ntfs3(&(0x7f000001f740), &(0x7f000001f780)='./file0\x00', 0x0, &(0x7f0000000200)=ANY=[@ANYBLOB="64697363==")
mkdirat(0xffffffffffffff9c, &(0x7f0000000600)='./file0aaaaaaaaaaaaaaaaa\x00', 0x0)
symlinkat(&(0x7f00000004c0)='./file0aaaaaaaaaa/file0\x00', 0xffffffffffffff9c, &(0x7f0000000280)='./file0aaaaaa/file0\x00')
`),
},
},
expect: []string{"ntfs3"},
},
{
name: `a bug with page cache in guilty path`,
crashes: []*subsystem.Crash{
{
GuiltyPath: `mm/filemap.c`,
},
{
GuiltyPath: `mm/filemap.c`,
SyzRepro: []byte(`# https://syzkaller.appspot.com/bug?id=cdaf5ed409125df023889aefe50b4cc4a41c0973
# See https://goo.gl/kgGztJ for information about syzkaller reproducers.
#{"threaded":true,"repeat":true,"procs":6,"slowdown":1,"sandbox":"","sandbox_arg":0,"close_fds":false,"ieee802154":true,"sysctl":true,"tmpdir":true,"segv":true}
syz_mount_image$ntfs3(&(0x7f000001f740), &(0x7f000001f780)='./file0\x00', 0x0, &(0x7f0000000200)=ANY=[@ANYBLOB="64697363==")
mkdirat(0xffffffffffffff9c, &(0x7f0000000600)='./file0aaaaaaaaaaaaaaaaa\x00', 0x0)
symlinkat(&(0x7f00000004c0)='./file0aaaaaaaaaa/file0\x00', 0xffffffffffffff9c, &(0x7f0000000280)='./file0aaaaaa/file0\x00')
`),
},
},
// There should be no mm in the subsystems.
expect: []string{"ntfs3"},
},
{
name: "dri bug with usb call",
crashes: []*subsystem.Crash{
{
GuiltyPath: `drivers/gpu/drm/udl/udl_drv.c`,
},
{
GuiltyPath: `drivers/gpu/drm/udl/udl_drv.c`,
SyzRepro: []byte(`
# https://syzkaller.appspot.com/bug?id=56e9aec9bc3b5378c9b231a3f4b3329cf9f80990
# See https://goo.gl/kgGztJ for information about syzkaller reproducers.
#{"procs":1,"slowdown":1,"sandbox":"none","sandbox_arg":0,"tun":true,"netdev":true,"close_fds":true}
syz_usb_connect(0x0, 0x24, &(0x7f0000000140)=ANY=[@ANYBLOB="12010000abbe6740e9174e8b089c000000010902120001000000000904000800ff"], 0x0)
`),
},
},
expect: []string{"dri", "usb"},
},
{
name: "ntfs bug with one ntfs guilty path",
crashes: []*subsystem.Crash{
{
GuiltyPath: `mm/folio-compat.c`,
},
{
GuiltyPath: `mm/folio-compat.c`,
},
{
GuiltyPath: `mm/folio-compat.c`,
},
{
// By chance just one was correct.
GuiltyPath: `fs/ntfs3/frecord.c`,
SyzRepro: []byte(`
# https://syzkaller.appspot.com/bug?id=9a239048a7fff1d8d9b276b240522a2293468dba
# See https://goo.gl/kgGztJ for information about syzkaller reproducers.
#{"procs":1,"slowdown":1,"sandbox":"","sandbox_arg":0,"close_fds":false}
syz_mount_image$ntfs3(&(0x7f000001f740), &(0x7f000001f780)='./file0\x00', 0x0, &(0x7f0000000200)=ANY=[@ANYBLOB="64697363==")
`),
},
{
GuiltyPath: `mm/folio-compat.c`,
SyzRepro: []byte(`
# https://syzkaller.appspot.com/bug?id=56e9aec9bc3b5378c9b231a3f4b3329cf9f80990
# See https://goo.gl/kgGztJ for information about syzkaller reproducers.
#{"procs":1,"slowdown":1,"sandbox":"none","sandbox_arg":0,"tun":true,"netdev":true,"close_fds":true}
syz_mount_image$ntfs3(&(0x7f000001f740), &(0x7f000001f780)='./file0\x00', 0x0, &(0x7f0000000200)=ANY=[@ANYBLOB="64697363==")
`),
},
},
expect: []string{"ntfs3"},
},
{
name: "many repros point to ntfs, all guilty files are wrong",
crashes: []*subsystem.Crash{
{
GuiltyPath: `arch/arm64/kernel/stacktrace.c`,
},
{
GuiltyPath: `arch/arm64/kernel/stacktrace.c`,
},
{
GuiltyPath: `arch/arm64/kernel/stacktrace.c`,
},
{
GuiltyPath: `arch/arm64/kernel/stacktrace.c`,
SyzRepro: []byte(`
syz_mount_image$ntfs3(&(0x7f000001f740), &(0x7f000001f780)='./file0\x00', 0x0, &(0x7f0000000200)=ANY=[@ANYBLOB="64697363==")
`),
},
{
GuiltyPath: `arch/arm64/kernel/stacktrace.c`,
SyzRepro: []byte(`
syz_mount_image$ntfs3(&(0x7f000001f740), &(0x7f000001f780)='./file0\x00', 0x0, &(0x7f0000000200)=ANY=[@ANYBLOB="64697363==")
`),
},
{
GuiltyPath: `arch/arm64/kernel/stacktrace.c`,
SyzRepro: []byte(`
syz_mount_image$ntfs3(&(0x7f000001f740), &(0x7f000001f780)='./file0\x00', 0x0, &(0x7f0000000200)=ANY=[@ANYBLOB="64697363==")
`),
},
},
// "arm" is just too omnipresent, we have to mention it.
expect: []string{"ntfs3", "arm"},
},
{
name: "guilty files point to media, many repros to usb",
crashes: []*subsystem.Crash{
{
// Suppose, in one case report parsing failed.
GuiltyPath: `arch/arm64/kernel/stacktrace.c`,
},
{
GuiltyPath: `drivers/media/mc/mc-entity.c`,
},
{
GuiltyPath: `drivers/media/mc/mc-entity.c`,
},
{
GuiltyPath: `drivers/media/mc/mc-entity.c`,
},
{
GuiltyPath: `drivers/media/mc/mc-entity.c`,
SyzRepro: []byte(`
syz_usb_connect(0x0, 0x58, &(0x7f0000000100)=ANY=[@ANYBLOB="1201000036ee3808d30b55056"])
`),
},
{
GuiltyPath: `drivers/media/mc/mc-entity.c`,
SyzRepro: []byte(`
syz_usb_connect(0x0, 0x58, &(0x7f0000000100)=ANY=[@ANYBLOB="1201000036ee3808d30b55056"])
`),
},
{
GuiltyPath: `drivers/media/mc/mc-entity.c`,
SyzRepro: []byte(`
syz_usb_connect(0x0, 0x58, &(0x7f0000000100)=ANY=[@ANYBLOB="1201000036ee3808d30b55056"])
`),
},
},
// "media" is picked because it's in >= 2/3 guilty paths.
expect: []string{"media", "usb"},
},
{
name: "wireless bug that should not be net",
crashes: []*subsystem.Crash{
{
GuiltyPath: `net/mac80211/rate.c`,
},
},
expect: []string{"wireless"},
},
{
name: "old ntfs bug",
crashes: []*subsystem.Crash{
{
GuiltyPath: `fs/ntfs/super.c`,
SyzRepro: []byte(`
syz_mount_image$ntfs(&AUTO, &AUTO, AUTO, &AUTO, AUTO, AUTO, &AUTO)`),
},
},
expect: []string{"ntfs3"},
},
{
// "p9" is no longer in "net".
name: "vf9fs bug",
crashes: []*subsystem.Crash{
{
GuiltyPath: `net/9p/client.c`,
},
},
expect: []string{"v9fs"},
},
}
for _, test := range tests {
t.Run(test.name, func(t *testing.T) {
names := []string{}
for _, e := range group.Extract(test.crashes) {
names = append(names, e.Name)
}
assert.ElementsMatch(t, names, test.expect, test.name)
})
}
}
|
