1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
|
// Copyright 2024 syzkaller project authors. All rights reserved.
// Use of this source code is governed by Apache 2 LICENSE that can be found in the LICENSE file.
package manager
import (
"context"
"sync/atomic"
"testing"
"time"
"github.com/google/syzkaller/pkg/report"
"github.com/stretchr/testify/assert"
)
func TestReproManager(t *testing.T) {
mock := &reproMgrMock{
run: make(chan runCallback),
}
obj := NewReproLoop(mock, 3, false)
// No reproductions until we've started.
assert.False(t, obj.CanReproMore())
ctx, done := context.WithCancel(context.Background())
complete := make(chan struct{})
go func() {
obj.Loop(ctx)
close(complete)
}()
defer func() {
done()
<-complete
}()
obj.Enqueue(&Crash{Report: &report.Report{Title: "A"}})
called := <-mock.run
assert.Equal(t, "A", called.crash.Title)
// One reproducer is running -- we can take one more.
assert.True(t, obj.CanReproMore())
assert.EqualValues(t, 2, mock.reserved.Load())
obj.Enqueue(&Crash{Report: &report.Report{Title: "B"}})
called2 := <-mock.run
assert.Equal(t, "B", called2.crash.Title)
assert.False(t, obj.CanReproMore())
assert.Len(t, obj.Reproducing(), 2)
assert.EqualValues(t, 3, mock.reserved.Load())
// Pretend that reproducers have finished.
called.ret <- &ReproResult{Crash: &Crash{FromHub: true}}
called2.ret <- &ReproResult{Crash: &Crash{FromHub: true}}
mock.onVMShutdown(t, obj)
}
func TestReproOrder(t *testing.T) {
mock := &reproMgrMock{
run: make(chan runCallback),
}
obj := NewReproLoop(mock, 1, false)
// The right order is A B C.
crashes := []*Crash{
{
Report: &report.Report{Title: "A"},
FromDashboard: true,
Manual: true,
},
{
Report: &report.Report{Title: "B"},
FromDashboard: true,
},
{
Report: &report.Report{Title: "C"},
FromHub: true,
},
}
obj.Enqueue(crashes[2])
obj.Enqueue(crashes[1])
obj.Enqueue(crashes[0])
obj.Enqueue(crashes[1])
obj.Enqueue(crashes[0])
obj.Enqueue(crashes[2])
ctx, cancel := context.WithCancel(context.Background())
defer cancel()
go obj.Loop(ctx)
for i := 0; i < len(crashes)*2; i++ {
called := <-mock.run
assert.Equal(t, crashes[i%len(crashes)], called.crash)
called.ret <- &ReproResult{}
}
}
func TestReproRWRace(t *testing.T) {
var reproProgExist atomic.Bool
mock := &reproMgrMock{
run: make(chan runCallback),
needReproCb: func(_ *Crash) bool {
return !reproProgExist.Load()
},
}
obj := NewReproLoop(mock, 3, false)
ctx, cancel := context.WithCancel(context.Background())
defer cancel()
go obj.Loop(ctx) // calls runRepro()
obj.Enqueue(&Crash{Report: &report.Report{Title: "A"}})
obj.Enqueue(&Crash{Report: &report.Report{Title: "A"}})
assert.True(t, mock.NeedRepro(nil))
called := <-mock.run
// Pretend that processRepro() is finished and
// we've written "repro.prog" to the disk.
reproProgExist.Store(true)
assert.False(t, mock.NeedRepro(nil))
called.ret <- &ReproResult{}
assert.True(t, obj.CanReproMore())
// The second repro process will never be started.
mock.onVMShutdown(t, obj)
}
func TestCancelRunningRepro(t *testing.T) {
mock := &reproMgrMock{
run: make(chan runCallback),
}
obj := NewReproLoop(mock, 1, false)
ctx, done := context.WithCancel(context.Background())
complete := make(chan struct{})
go func() {
obj.Loop(ctx)
close(complete)
}()
defer func() {
<-complete
}()
obj.Enqueue(&Crash{Report: &report.Report{Title: "A"}})
obj.Enqueue(&Crash{Report: &report.Report{Title: "B"}})
<-mock.run
done()
}
func TestEnqueueTriggersRepro(t *testing.T) {
mock := &reproMgrMock{
run: make(chan runCallback),
needReproCb: func(crash *Crash) bool {
return crash.FullTitle() == "C"
},
}
obj := NewReproLoop(mock, 1, false)
obj.Enqueue(&Crash{Report: &report.Report{Title: "A"}, Manual: true})
obj.Enqueue(&Crash{Report: &report.Report{Title: "B"}, Manual: true})
obj.Enqueue(&Crash{Report: &report.Report{Title: "C"}})
ctx, done := context.WithCancel(context.Background())
complete := make(chan struct{})
go func() {
obj.Loop(ctx)
close(complete)
}()
defer func() {
<-complete
}()
// The test will hang if the loop never picks up the title C.
crash := <-mock.run
assert.Equal(t, "C", crash.crash.FullTitle())
done()
}
type reproMgrMock struct {
reserved atomic.Int64
run chan runCallback
needReproCb func(*Crash) bool
}
type runCallback struct {
crash *Crash
ret chan *ReproResult
}
// Wait until the number of reserved VMs goes to 0.
func (m *reproMgrMock) onVMShutdown(t *testing.T, reproLoop *ReproLoop) {
for i := 0; i < 100; i++ {
if m.reserved.Load() == 0 {
assert.True(t, reproLoop.CanReproMore())
assert.True(t, reproLoop.Empty())
return
}
time.Sleep(10 * time.Millisecond)
}
t.Fatal("reserved VMs must have dropped to 0")
}
func (m *reproMgrMock) RunRepro(ctx context.Context, crash *Crash) *ReproResult {
retCh := make(chan *ReproResult)
select {
case m.run <- runCallback{crash: crash, ret: retCh}:
case <-ctx.Done():
return &ReproResult{}
}
var ret *ReproResult
select {
case ret = <-retCh:
case <-ctx.Done():
return &ReproResult{}
}
close(retCh)
return ret
}
func (m *reproMgrMock) NeedRepro(crash *Crash) bool {
if m.needReproCb != nil {
return m.needReproCb(crash)
}
return true
}
func (m *reproMgrMock) ResizeReproPool(VMs int) {
m.reserved.Store(int64(VMs))
}
|
