aboutsummaryrefslogtreecommitdiffstats
path: root/syz-manager
diff options
context:
space:
mode:
authorAleksandr Nogikh <nogikh@google.com>2025-02-06 15:06:26 +0100
committerAleksandr Nogikh <nogikh@google.com>2025-02-06 15:31:42 +0100
commit55e0929fab461fee7733a18f8b543f9a5d6b9f6f (patch)
tree3cc63faa3c1b4695cccd89cf5c85ec9b5163901e /syz-manager
parent8d4a47e6d71a9ca2dd769765a52e01c9c897c946 (diff)
all: enable run_fsck by default
Check for the existence of fsck binaries and report their absence only once.
Diffstat (limited to 'syz-manager')
-rw-r--r--syz-manager/manager.go6
1 files changed, 4 insertions, 2 deletions
diff --git a/syz-manager/manager.go b/syz-manager/manager.go
index fdb4929d7..b0354ea61 100644
--- a/syz-manager/manager.go
+++ b/syz-manager/manager.go
@@ -106,6 +106,7 @@ type Manager struct {
benchFile *os.File
assetStorage *asset.Storage
+ fsckChecker image.FsckChecker
reproLoop *manager.ReproLoop
@@ -944,10 +945,11 @@ func (mgr *Manager) uploadReproAssets(repro *repro.Result) []dashapi.NewAsset {
return
}
// Report file systems that fail fsck with a separate tag.
- if mgr.cfg.RunFsck && dashTyp == dashapi.MountInRepro && c.Meta.Attrs.Fsck != "" {
+ if mgr.cfg.RunFsck && dashTyp == dashapi.MountInRepro &&
+ c.Meta.Attrs.Fsck != "" && mgr.fsckChecker.Exists(c.Meta.Attrs.Fsck) {
logs, isClean, err := image.Fsck(r2, c.Meta.Attrs.Fsck)
if err != nil {
- log.Logf(1, "fsck of the asset %v failed: %v", name, err)
+ log.Errorf("fsck of the asset %v failed: %v", name, err)
} else {
asset.FsckLog = logs
asset.FsIsClean = isClean