From 55e0929fab461fee7733a18f8b543f9a5d6b9f6f Mon Sep 17 00:00:00 2001 From: Aleksandr Nogikh Date: Thu, 6 Feb 2025 15:06:26 +0100 Subject: all: enable run_fsck by default Check for the existence of fsck binaries and report their absence only once. --- syz-manager/manager.go | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) (limited to 'syz-manager') diff --git a/syz-manager/manager.go b/syz-manager/manager.go index fdb4929d7..b0354ea61 100644 --- a/syz-manager/manager.go +++ b/syz-manager/manager.go @@ -106,6 +106,7 @@ type Manager struct { benchFile *os.File assetStorage *asset.Storage + fsckChecker image.FsckChecker reproLoop *manager.ReproLoop @@ -944,10 +945,11 @@ func (mgr *Manager) uploadReproAssets(repro *repro.Result) []dashapi.NewAsset { return } // Report file systems that fail fsck with a separate tag. - if mgr.cfg.RunFsck && dashTyp == dashapi.MountInRepro && c.Meta.Attrs.Fsck != "" { + if mgr.cfg.RunFsck && dashTyp == dashapi.MountInRepro && + c.Meta.Attrs.Fsck != "" && mgr.fsckChecker.Exists(c.Meta.Attrs.Fsck) { logs, isClean, err := image.Fsck(r2, c.Meta.Attrs.Fsck) if err != nil { - log.Logf(1, "fsck of the asset %v failed: %v", name, err) + log.Errorf("fsck of the asset %v failed: %v", name, err) } else { asset.FsckLog = logs asset.FsIsClean = isClean -- cgit mrf-deployment