diff options
| author | Dmitry Vyukov <dvyukov@google.com> | 2018-01-10 09:41:28 +0100 |
|---|---|---|
| committer | Dmitry Vyukov <dvyukov@google.com> | 2018-01-10 09:41:28 +0100 |
| commit | 02a19b646c19a4a75c3efc00a32c564eeabb4bdf (patch) | |
| tree | b273407537e39fa55f301bb0a0182b269e1c2de1 /syz-manager | |
| parent | 1f60c8289d52323ee321586fb3e96bb91a0de542 (diff) | |
syz-manager: add comment explaining why we don't set corrupted for repros
Diffstat (limited to 'syz-manager')
| -rw-r--r-- | syz-manager/manager.go | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/syz-manager/manager.go b/syz-manager/manager.go index 05c25101d..3e40bccb8 100644 --- a/syz-manager/manager.go +++ b/syz-manager/manager.go @@ -769,6 +769,11 @@ func (mgr *Manager) saveRepro(res *repro.Result, hub bool) { } if mgr.dash != nil { + // Note: we intentionally don't set Corrupted for reproducers: + // 1. This is reproducible so can be debugged even with corrupted report. + // 2. Repro re-tried 3 times and still got corrupted report at the end, + // so maybe corrupted report detection is broken. + // 3. Reproduction is expensive so it's good to persist the result. dc := &dashapi.Crash{ BuildID: mgr.cfg.Tag, Title: res.Report.Title, |