From 02a19b646c19a4a75c3efc00a32c564eeabb4bdf Mon Sep 17 00:00:00 2001 From: Dmitry Vyukov Date: Wed, 10 Jan 2018 09:41:28 +0100 Subject: syz-manager: add comment explaining why we don't set corrupted for repros --- syz-manager/manager.go | 5 +++++ 1 file changed, 5 insertions(+) (limited to 'syz-manager') diff --git a/syz-manager/manager.go b/syz-manager/manager.go index 05c25101d..3e40bccb8 100644 --- a/syz-manager/manager.go +++ b/syz-manager/manager.go @@ -769,6 +769,11 @@ func (mgr *Manager) saveRepro(res *repro.Result, hub bool) { } if mgr.dash != nil { + // Note: we intentionally don't set Corrupted for reproducers: + // 1. This is reproducible so can be debugged even with corrupted report. + // 2. Repro re-tried 3 times and still got corrupted report at the end, + // so maybe corrupted report detection is broken. + // 3. Reproduction is expensive so it's good to persist the result. dc := &dashapi.Crash{ BuildID: mgr.cfg.Tag, Title: res.Report.Title, -- cgit mrf-deployment