aboutsummaryrefslogtreecommitdiffstats
path: root/pkg
diff options
context:
space:
mode:
authorDmitry Vyukov <dvyukov@google.com>2021-03-16 21:01:43 +0100
committerDmitry Vyukov <dvyukov@google.com>2021-03-18 09:17:51 +0100
commitd791e31f76f8479015ac2a482c9784c2db1caee4 (patch)
tree276c44e9cd82d81acf370bd3bc441b42b43c7952 /pkg
parentd3c31814bca5812360f650cb04b6e1f426dc52e5 (diff)
pkg/cover: avoid "else if" after return
Avoid double check for err != nil and else if after return statement.
Diffstat (limited to 'pkg')
-rw-r--r--pkg/cover/backend/elf.go9
1 files changed, 5 insertions, 4 deletions
diff --git a/pkg/cover/backend/elf.go b/pkg/cover/backend/elf.go
index ad507eea9..00b8bb776 100644
--- a/pkg/cover/backend/elf.go
+++ b/pkg/cover/backend/elf.go
@@ -351,11 +351,12 @@ func readTextRanges(file *elf.File, module *Module) ([]pcRange, []*CompileUnit,
}
kaslr := file.Section(".rela.text") != nil
debugInfo, err := file.DWARF()
- if err != nil && module.Name == "" {
+ if err != nil {
+ if module.Name != "" {
+ log.Logf(0, "ignoring module %v without DEBUG_INFO", module.Name)
+ return nil, nil, nil
+ }
return nil, nil, fmt.Errorf("failed to parse DWARF: %v (set CONFIG_DEBUG_INFO=y?)", err)
- } else if err != nil {
- log.Logf(0, "ignore module %v which doesn't have DEBUG_INFO", module.Name)
- return nil, nil, nil
}
var ranges []pcRange
var units []*CompileUnit