From d791e31f76f8479015ac2a482c9784c2db1caee4 Mon Sep 17 00:00:00 2001 From: Dmitry Vyukov Date: Tue, 16 Mar 2021 21:01:43 +0100 Subject: pkg/cover: avoid "else if" after return Avoid double check for err != nil and else if after return statement. --- pkg/cover/backend/elf.go | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) (limited to 'pkg') diff --git a/pkg/cover/backend/elf.go b/pkg/cover/backend/elf.go index ad507eea9..00b8bb776 100644 --- a/pkg/cover/backend/elf.go +++ b/pkg/cover/backend/elf.go @@ -351,11 +351,12 @@ func readTextRanges(file *elf.File, module *Module) ([]pcRange, []*CompileUnit, } kaslr := file.Section(".rela.text") != nil debugInfo, err := file.DWARF() - if err != nil && module.Name == "" { + if err != nil { + if module.Name != "" { + log.Logf(0, "ignoring module %v without DEBUG_INFO", module.Name) + return nil, nil, nil + } return nil, nil, fmt.Errorf("failed to parse DWARF: %v (set CONFIG_DEBUG_INFO=y?)", err) - } else if err != nil { - log.Logf(0, "ignore module %v which doesn't have DEBUG_INFO", module.Name) - return nil, nil, nil } var ranges []pcRange var units []*CompileUnit -- cgit mrf-deployment