diff options
| author | Taras Madan <tarasmadan@google.com> | 2024-11-07 14:03:48 +0100 |
|---|---|---|
| committer | Taras Madan <tarasmadan@google.com> | 2024-11-07 13:22:50 +0000 |
| commit | c069283c08fdf374781b75452d49c5a29e92a8c3 (patch) | |
| tree | e3bb4e430c71347d5121087cda9a405f966778a8 /pkg/validator/validator_test.go | |
| parent | 47bec44cc2d85a07e7b707bc345e5ef947b59401 (diff) | |
pkg/validator: fix regexp mistake
The main problem - kernel file path may contain "-". Let's allow it.
Side problems:
1. Two -- are better to be blocked. It may be used as an SQL comment.
2. Some regexp engines consider "-" as a range. Let's move it to the end.
Diffstat (limited to 'pkg/validator/validator_test.go')
| -rw-r--r-- | pkg/validator/validator_test.go | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/pkg/validator/validator_test.go b/pkg/validator/validator_test.go index 6397081e4..9aa08e2d0 100644 --- a/pkg/validator/validator_test.go +++ b/pkg/validator/validator_test.go @@ -58,12 +58,13 @@ func TestIsDashboardClientKey(t *testing.T) { // nolint: dupl func TestIsKernelFilePath(t *testing.T) { assert.True(t, validator.KernelFilePath("io_uring/advise.c").Ok) - assert.False(t, validator.KernelFilePath("io-uring/advise.c").Ok) + assert.True(t, validator.KernelFilePath("io-uring/advise.c").Ok) + assert.False(t, validator.KernelFilePath("io--uring/advise.c").Ok) assert.False(t, validator.KernelFilePath("").Ok) - assert.Equal(t, "not a kernel file path", validator.KernelFilePath("io-uring").Err.Error()) + assert.Equal(t, "not a kernel file path", validator.KernelFilePath("io--uring").Err.Error()) assert.Equal(t, "kernelPath: not a kernel file path", - validator.KernelFilePath("io-uring", "kernelPath").Err.Error()) + validator.KernelFilePath("io--uring", "kernelPath").Err.Error()) } var badResult = validator.Result{false, errors.New("sample error")} |