From c069283c08fdf374781b75452d49c5a29e92a8c3 Mon Sep 17 00:00:00 2001 From: Taras Madan Date: Thu, 7 Nov 2024 14:03:48 +0100 Subject: pkg/validator: fix regexp mistake The main problem - kernel file path may contain "-". Let's allow it. Side problems: 1. Two -- are better to be blocked. It may be used as an SQL comment. 2. Some regexp engines consider "-" as a range. Let's move it to the end. --- pkg/validator/validator_test.go | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) (limited to 'pkg/validator/validator_test.go') diff --git a/pkg/validator/validator_test.go b/pkg/validator/validator_test.go index 6397081e4..9aa08e2d0 100644 --- a/pkg/validator/validator_test.go +++ b/pkg/validator/validator_test.go @@ -58,12 +58,13 @@ func TestIsDashboardClientKey(t *testing.T) { // nolint: dupl func TestIsKernelFilePath(t *testing.T) { assert.True(t, validator.KernelFilePath("io_uring/advise.c").Ok) - assert.False(t, validator.KernelFilePath("io-uring/advise.c").Ok) + assert.True(t, validator.KernelFilePath("io-uring/advise.c").Ok) + assert.False(t, validator.KernelFilePath("io--uring/advise.c").Ok) assert.False(t, validator.KernelFilePath("").Ok) - assert.Equal(t, "not a kernel file path", validator.KernelFilePath("io-uring").Err.Error()) + assert.Equal(t, "not a kernel file path", validator.KernelFilePath("io--uring").Err.Error()) assert.Equal(t, "kernelPath: not a kernel file path", - validator.KernelFilePath("io-uring", "kernelPath").Err.Error()) + validator.KernelFilePath("io--uring", "kernelPath").Err.Error()) } var badResult = validator.Result{false, errors.New("sample error")} -- cgit mrf-deployment