diff options
| author | Dmitry Vyukov <dvyukov@google.com> | 2023-02-22 07:53:26 +0100 |
|---|---|---|
| committer | Dmitry Vyukov <dvyukov@google.com> | 2023-02-22 11:30:20 +0100 |
| commit | 409945bc8fab54efa11597029f5c9704bf0cbc22 (patch) | |
| tree | 68fb9518ea4717056cd54c5afab3673645b8d2bf /pkg/report/linux.go | |
| parent | 42a4d50890beed97e5e9868be922faa6285f4a12 (diff) | |
pkg/report: improve Go throw/panic parsing
This several small improvements:
1. Move these patterns into the common part.
We run Go code on (almost) all OSes and error messages
are the same for all of them.
2. Detect "fatal error:" as a bug as well.
This is what I currently see from Go 1.20 runtime,
but we don't recognize it, so these reports probably
go into "lost connection" bucket now (bad).
3. Add a pattern for panic(ENOMEM) message.
pkg/image/compression_optimized.go can produce it
on mmap failure.
4. Add tests.
Diffstat (limited to 'pkg/report/linux.go')
| -rw-r--r-- | pkg/report/linux.go | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/pkg/report/linux.go b/pkg/report/linux.go index 320f5b148..df955b748 100644 --- a/pkg/report/linux.go +++ b/pkg/report/linux.go @@ -115,8 +115,6 @@ func ctorLinux(cfg *config) (reporterImpl, []string, error) { []byte("FAULT_FLAG_ALLOW_RETRY missing"), } suppressions := []string{ - "fatal error: runtime: out of memory", - "fatal error: runtime: cannot allocate memory", "panic: failed to start executor binary", "panic: executor failed: pthread_create failed", "panic: failed to create temp dir", |