From 409945bc8fab54efa11597029f5c9704bf0cbc22 Mon Sep 17 00:00:00 2001 From: Dmitry Vyukov Date: Wed, 22 Feb 2023 07:53:26 +0100 Subject: pkg/report: improve Go throw/panic parsing This several small improvements: 1. Move these patterns into the common part. We run Go code on (almost) all OSes and error messages are the same for all of them. 2. Detect "fatal error:" as a bug as well. This is what I currently see from Go 1.20 runtime, but we don't recognize it, so these reports probably go into "lost connection" bucket now (bad). 3. Add a pattern for panic(ENOMEM) message. pkg/image/compression_optimized.go can produce it on mmap failure. 4. Add tests. --- pkg/report/linux.go | 2 -- 1 file changed, 2 deletions(-) (limited to 'pkg/report/linux.go') diff --git a/pkg/report/linux.go b/pkg/report/linux.go index 320f5b148..df955b748 100644 --- a/pkg/report/linux.go +++ b/pkg/report/linux.go @@ -115,8 +115,6 @@ func ctorLinux(cfg *config) (reporterImpl, []string, error) { []byte("FAULT_FLAG_ALLOW_RETRY missing"), } suppressions := []string{ - "fatal error: runtime: out of memory", - "fatal error: runtime: cannot allocate memory", "panic: failed to start executor binary", "panic: executor failed: pthread_create failed", "panic: failed to create temp dir", -- cgit mrf-deployment