diff options
| author | Aleksandr Nogikh <nogikh@google.com> | 2025-08-05 21:52:15 +0200 |
|---|---|---|
| committer | Aleksandr Nogikh <nogikh@google.com> | 2025-08-06 09:55:41 +0000 |
| commit | 745510422fa0fd508f681b06c98e3a74d41344c5 (patch) | |
| tree | aa2563d9870e90c081bd481a7046b5bc2964bd77 /pkg/manager/diff.go | |
| parent | 5ba0fed13435213276f29e3d9e39d926f04ac1a8 (diff) | |
pkg/manager: fix a NeedRepro check
It's been checking the inverse of what was needed.
Rename the helper function to reduce confusion in the future.
Diffstat (limited to 'pkg/manager/diff.go')
| -rw-r--r-- | pkg/manager/diff.go | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/pkg/manager/diff.go b/pkg/manager/diff.go index ae05f7a97..c88e88903 100644 --- a/pkg/manager/diff.go +++ b/pkg/manager/diff.go @@ -323,23 +323,23 @@ func (dc *diffContext) monitorPatchedCoverage(ctx context.Context) error { // TODO: instead of this limit, consider expotentially growing delays between reproduction attempts. const maxReproAttempts = 6 -func skipDiffRepro(title string) bool { +func needReproForTitle(title string) bool { if strings.Contains(title, "no output") || strings.Contains(title, "lost connection") || strings.Contains(title, "detected stall") || strings.Contains(title, "SYZ") { // Don't waste time reproducing these. - return true + return false } - return false + return true } func (dc *diffContext) NeedRepro(crash *Crash) bool { if crash.FullRepro { return true } - if skipDiffRepro(crash.Title) { - return true + if !needReproForTitle(crash.Title) { + return false } dc.mu.Lock() defer dc.mu.Unlock() |
