From 745510422fa0fd508f681b06c98e3a74d41344c5 Mon Sep 17 00:00:00 2001 From: Aleksandr Nogikh Date: Tue, 5 Aug 2025 21:52:15 +0200 Subject: pkg/manager: fix a NeedRepro check It's been checking the inverse of what was needed. Rename the helper function to reduce confusion in the future. --- pkg/manager/diff.go | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) (limited to 'pkg/manager/diff.go') diff --git a/pkg/manager/diff.go b/pkg/manager/diff.go index ae05f7a97..c88e88903 100644 --- a/pkg/manager/diff.go +++ b/pkg/manager/diff.go @@ -323,23 +323,23 @@ func (dc *diffContext) monitorPatchedCoverage(ctx context.Context) error { // TODO: instead of this limit, consider expotentially growing delays between reproduction attempts. const maxReproAttempts = 6 -func skipDiffRepro(title string) bool { +func needReproForTitle(title string) bool { if strings.Contains(title, "no output") || strings.Contains(title, "lost connection") || strings.Contains(title, "detected stall") || strings.Contains(title, "SYZ") { // Don't waste time reproducing these. - return true + return false } - return false + return true } func (dc *diffContext) NeedRepro(crash *Crash) bool { if crash.FullRepro { return true } - if skipDiffRepro(crash.Title) { - return true + if !needReproForTitle(crash.Title) { + return false } dc.mu.Lock() defer dc.mu.Unlock() -- cgit mrf-deployment