aboutsummaryrefslogtreecommitdiffstats
path: root/pkg/instance
diff options
context:
space:
mode:
authorAleksandr Nogikh <nogikh@google.com>2021-07-14 17:01:48 +0000
committerAleksandr Nogikh <wp32pw@gmail.com>2021-07-20 13:39:45 +0200
commitb5969a9bdd1769ae7dc56682c4dbb8bc8f2ab7c3 (patch)
tree1859559654383d8f1b771ece935aca6a1b6371c0 /pkg/instance
parentbc48c9ab65ed47d707bedef64ca52e1a5c383250 (diff)
all: remove pointers to pkg.build.Params
The struct pkg.build.Params is currently primarily passed on as a pointer, which leads make it hard to see the places, where it can (and should) actually be modified. Make it all more explicit by only passing pointer references to objects of this type when the object is expected to be modified by the function. In fact, at this moment there are no such situations.
Diffstat (limited to 'pkg/instance')
-rw-r--r--pkg/instance/instance.go2
1 files changed, 1 insertions, 1 deletions
diff --git a/pkg/instance/instance.go b/pkg/instance/instance.go
index e0c1e3ce8..3e28f2170 100644
--- a/pkg/instance/instance.go
+++ b/pkg/instance/instance.go
@@ -108,7 +108,7 @@ func (env *env) BuildSyzkaller(repoURL, commit string) error {
func (env *env) BuildKernel(compilerBin, ccacheBin, userspaceDir, cmdlineFile, sysctlFile string, kernelConfig []byte) (
string, string, error) {
imageDir := filepath.Join(env.cfg.Workdir, "image")
- params := &build.Params{
+ params := build.Params{
TargetOS: env.cfg.TargetOS,
TargetArch: env.cfg.TargetVMArch,
VMType: env.cfg.Type,