From b5969a9bdd1769ae7dc56682c4dbb8bc8f2ab7c3 Mon Sep 17 00:00:00 2001 From: Aleksandr Nogikh Date: Wed, 14 Jul 2021 17:01:48 +0000 Subject: all: remove pointers to pkg.build.Params The struct pkg.build.Params is currently primarily passed on as a pointer, which leads make it hard to see the places, where it can (and should) actually be modified. Make it all more explicit by only passing pointer references to objects of this type when the object is expected to be modified by the function. In fact, at this moment there are no such situations. --- pkg/instance/instance.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'pkg/instance') diff --git a/pkg/instance/instance.go b/pkg/instance/instance.go index e0c1e3ce8..3e28f2170 100644 --- a/pkg/instance/instance.go +++ b/pkg/instance/instance.go @@ -108,7 +108,7 @@ func (env *env) BuildSyzkaller(repoURL, commit string) error { func (env *env) BuildKernel(compilerBin, ccacheBin, userspaceDir, cmdlineFile, sysctlFile string, kernelConfig []byte) ( string, string, error) { imageDir := filepath.Join(env.cfg.Workdir, "image") - params := &build.Params{ + params := build.Params{ TargetOS: env.cfg.TargetOS, TargetArch: env.cfg.TargetVMArch, VMType: env.cfg.Type, -- cgit mrf-deployment