aboutsummaryrefslogtreecommitdiffstats
path: root/pkg/coveragedb
diff options
context:
space:
mode:
authorTaras Madan <tarasmadan@google.com>2024-12-12 15:35:24 +0100
committerTaras Madan <tarasmadan@google.com>2024-12-12 15:52:20 +0000
commit4ea1fe6aae47bcfc828797d283ecbc755682e7c9 (patch)
tree3569552ec09ef36f3c8cece37521f18b60f394df /pkg/coveragedb
parent5388eec6a1e6628f5ba367193f4131e82074ab3b (diff)
tools/syz-covermerger: more logs
I don't see any visible problems but the records in DB are not created. Let's report the amount of records created at the end of the batch step. +log the names of the managers
Diffstat (limited to 'pkg/coveragedb')
-rw-r--r--pkg/coveragedb/spanner.go12
1 files changed, 7 insertions, 5 deletions
diff --git a/pkg/coveragedb/spanner.go b/pkg/coveragedb/spanner.go
index 5bbe4cbbb..db6d9ac79 100644
--- a/pkg/coveragedb/spanner.go
+++ b/pkg/coveragedb/spanner.go
@@ -73,12 +73,13 @@ func (c *Coverage) AddLineHitCount(line, hitCount int) {
}
func SaveMergeResult(ctx context.Context, projectID string, manCovMap ManagersCoverage,
- template *HistoryRecord, totalRows int64, sss []*subsystem.Subsystem) error {
+ template *HistoryRecord, totalRows int64, sss []*subsystem.Subsystem) (int, error) {
client, err := NewClient(ctx, projectID)
if err != nil {
- return fmt.Errorf("spanner.NewClient() failed: %s", err.Error())
+ return 0, fmt.Errorf("spanner.NewClient() failed: %s", err.Error())
}
defer client.Close()
+ var rowsCreated int
ssMatcher := subsystem.MakePathMatcher(sss)
ssCache := make(map[string][]string)
@@ -97,17 +98,18 @@ func SaveMergeResult(ctx context.Context, projectID string, manCovMap ManagersCo
// We keep the number of records low enough for the number of explicit mutations * 10 does not exceed the limit.
if len(mutations) > 1000 {
if _, err = client.Apply(ctx, mutations); err != nil {
- return fmt.Errorf("failed to spanner.Apply(inserts): %s", err.Error())
+ return rowsCreated, fmt.Errorf("failed to spanner.Apply(inserts): %s", err.Error())
}
+ rowsCreated += len(mutations)
mutations = nil
}
}
}
mutations = append(mutations, historyMutation(session, template, totalRows))
if _, err = client.Apply(ctx, mutations); err != nil {
- return fmt.Errorf("failed to spanner.Apply(inserts): %s", err.Error())
+ return rowsCreated, fmt.Errorf("failed to spanner.Apply(inserts): %s", err.Error())
}
- return nil
+ return rowsCreated, nil
}
type linesCoverage struct {