From 4ea1fe6aae47bcfc828797d283ecbc755682e7c9 Mon Sep 17 00:00:00 2001 From: Taras Madan Date: Thu, 12 Dec 2024 15:35:24 +0100 Subject: tools/syz-covermerger: more logs I don't see any visible problems but the records in DB are not created. Let's report the amount of records created at the end of the batch step. +log the names of the managers --- pkg/coveragedb/spanner.go | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) (limited to 'pkg/coveragedb') diff --git a/pkg/coveragedb/spanner.go b/pkg/coveragedb/spanner.go index 5bbe4cbbb..db6d9ac79 100644 --- a/pkg/coveragedb/spanner.go +++ b/pkg/coveragedb/spanner.go @@ -73,12 +73,13 @@ func (c *Coverage) AddLineHitCount(line, hitCount int) { } func SaveMergeResult(ctx context.Context, projectID string, manCovMap ManagersCoverage, - template *HistoryRecord, totalRows int64, sss []*subsystem.Subsystem) error { + template *HistoryRecord, totalRows int64, sss []*subsystem.Subsystem) (int, error) { client, err := NewClient(ctx, projectID) if err != nil { - return fmt.Errorf("spanner.NewClient() failed: %s", err.Error()) + return 0, fmt.Errorf("spanner.NewClient() failed: %s", err.Error()) } defer client.Close() + var rowsCreated int ssMatcher := subsystem.MakePathMatcher(sss) ssCache := make(map[string][]string) @@ -97,17 +98,18 @@ func SaveMergeResult(ctx context.Context, projectID string, manCovMap ManagersCo // We keep the number of records low enough for the number of explicit mutations * 10 does not exceed the limit. if len(mutations) > 1000 { if _, err = client.Apply(ctx, mutations); err != nil { - return fmt.Errorf("failed to spanner.Apply(inserts): %s", err.Error()) + return rowsCreated, fmt.Errorf("failed to spanner.Apply(inserts): %s", err.Error()) } + rowsCreated += len(mutations) mutations = nil } } } mutations = append(mutations, historyMutation(session, template, totalRows)) if _, err = client.Apply(ctx, mutations); err != nil { - return fmt.Errorf("failed to spanner.Apply(inserts): %s", err.Error()) + return rowsCreated, fmt.Errorf("failed to spanner.Apply(inserts): %s", err.Error()) } - return nil + return rowsCreated, nil } type linesCoverage struct { -- cgit mrf-deployment