diff options
| author | Taras Madan <tarasmadan@google.com> | 2024-03-15 21:21:01 +0100 |
|---|---|---|
| committer | Taras Madan <tarasmadan@google.com> | 2024-03-20 10:11:25 +0000 |
| commit | 2c154a8fc72ca5d6a1a6f519d43e943cf5d2957f (patch) | |
| tree | a8d54f2831e29aa19c77f18bee2412a945070f7d /pkg/cover/html.go | |
| parent | a485f2390d41decb9fca41e15902295e293464d2 (diff) | |
pkg/cover: add full symbolization for /cover?jsonl=1
Diffstat (limited to 'pkg/cover/html.go')
| -rw-r--r-- | pkg/cover/html.go | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/pkg/cover/html.go b/pkg/cover/html.go index 1411bdf62..bfceca2be 100644 --- a/pkg/cover/html.go +++ b/pkg/cover/html.go @@ -186,7 +186,7 @@ func fileLineContents(file *file, lines [][]byte) lineCoverExport { func (rg *ReportGenerator) DoRawCoverFiles(w io.Writer, params CoverHandlerParams) error { progs := fixUpPCs(rg.target.Arch, params.Progs, params.CoverFilter) - if err := rg.lazySymbolize(progs); err != nil { + if err := rg.symbolizePCs(uniquePCs(progs)); err != nil { return err } @@ -226,6 +226,9 @@ type coverageInfo struct { // DoCoverJSONL is a handler for "/cover?jsonl=1". func (rg *ReportGenerator) DoCoverJSONL(w io.Writer, params CoverHandlerParams) error { + if err := rg.symbolizePCs(rg.CoverageCallbackPoints); err != nil { + return fmt.Errorf("failed to rg.fullSymbolize(): %w", err) + } var progs = fixUpPCs(rg.target.Arch, params.Progs, params.CoverFilter) fm, err := rg.prepareFileMap(progs, params.Debug) if err != nil { |
