From 2c154a8fc72ca5d6a1a6f519d43e943cf5d2957f Mon Sep 17 00:00:00 2001 From: Taras Madan Date: Fri, 15 Mar 2024 21:21:01 +0100 Subject: pkg/cover: add full symbolization for /cover?jsonl=1 --- pkg/cover/html.go | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) (limited to 'pkg/cover/html.go') diff --git a/pkg/cover/html.go b/pkg/cover/html.go index 1411bdf62..bfceca2be 100644 --- a/pkg/cover/html.go +++ b/pkg/cover/html.go @@ -186,7 +186,7 @@ func fileLineContents(file *file, lines [][]byte) lineCoverExport { func (rg *ReportGenerator) DoRawCoverFiles(w io.Writer, params CoverHandlerParams) error { progs := fixUpPCs(rg.target.Arch, params.Progs, params.CoverFilter) - if err := rg.lazySymbolize(progs); err != nil { + if err := rg.symbolizePCs(uniquePCs(progs)); err != nil { return err } @@ -226,6 +226,9 @@ type coverageInfo struct { // DoCoverJSONL is a handler for "/cover?jsonl=1". func (rg *ReportGenerator) DoCoverJSONL(w io.Writer, params CoverHandlerParams) error { + if err := rg.symbolizePCs(rg.CoverageCallbackPoints); err != nil { + return fmt.Errorf("failed to rg.fullSymbolize(): %w", err) + } var progs = fixUpPCs(rg.target.Arch, params.Progs, params.CoverFilter) fm, err := rg.prepareFileMap(progs, params.Debug) if err != nil { -- cgit mrf-deployment