diff options
| author | Dmitry Vyukov <dvyukov@google.com> | 2019-03-29 11:00:34 +0100 |
|---|---|---|
| committer | Dmitry Vyukov <dvyukov@google.com> | 2019-03-29 11:00:34 +0100 |
| commit | 9633c5c8a1a030cdfdc0f94ae460314c7fc15faa (patch) | |
| tree | 01efde3d54f1261007510e6662045f07f1621cd2 /pkg/build/netbsd.go | |
| parent | 6b138f0f3ced97b0260f6253874d7c84c6408662 (diff) | |
pkg/build: extract bazel build errors
We currently manually call extractRootCause in few selected places
to denote kernel build errors that we want to report to developers.
The rest are considered infra errors that we don't report.
This does not work well. We are missing fuchsia and gvisor build errors.
Treat all external command exection failures as kernel build errors instead.
Let's see how this works in practice.
Also add bazel-specfic error patterns and tests.
Diffstat (limited to 'pkg/build/netbsd.go')
| -rw-r--r-- | pkg/build/netbsd.go | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/pkg/build/netbsd.go b/pkg/build/netbsd.go index 91280577e..315a996f6 100644 --- a/pkg/build/netbsd.go +++ b/pkg/build/netbsd.go @@ -41,13 +41,13 @@ no options SVS // Build tools before building kernel if _, err := osutil.RunCmd(10*time.Minute, kernelDir, "./build.sh", "-m", targetArch, "-U", "-u", "-j"+strconv.Itoa(runtime.NumCPU()), "tools"); err != nil { - return extractRootCause(err) + return err } // Build kernel if _, err := osutil.RunCmd(10*time.Minute, kernelDir, "./build.sh", "-m", targetArch, "-U", "-u", "-j"+strconv.Itoa(runtime.NumCPU()), "kernel="+kernelName); err != nil { - return extractRootCause(err) + return err } for _, s := range []struct{ dir, src, dst string }{ {compileDir, "netbsd.gdb", "obj/netbsd.gdb"}, |