From 9633c5c8a1a030cdfdc0f94ae460314c7fc15faa Mon Sep 17 00:00:00 2001 From: Dmitry Vyukov Date: Fri, 29 Mar 2019 11:00:34 +0100 Subject: pkg/build: extract bazel build errors We currently manually call extractRootCause in few selected places to denote kernel build errors that we want to report to developers. The rest are considered infra errors that we don't report. This does not work well. We are missing fuchsia and gvisor build errors. Treat all external command exection failures as kernel build errors instead. Let's see how this works in practice. Also add bazel-specfic error patterns and tests. --- pkg/build/netbsd.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'pkg/build/netbsd.go') diff --git a/pkg/build/netbsd.go b/pkg/build/netbsd.go index 91280577e..315a996f6 100644 --- a/pkg/build/netbsd.go +++ b/pkg/build/netbsd.go @@ -41,13 +41,13 @@ no options SVS // Build tools before building kernel if _, err := osutil.RunCmd(10*time.Minute, kernelDir, "./build.sh", "-m", targetArch, "-U", "-u", "-j"+strconv.Itoa(runtime.NumCPU()), "tools"); err != nil { - return extractRootCause(err) + return err } // Build kernel if _, err := osutil.RunCmd(10*time.Minute, kernelDir, "./build.sh", "-m", targetArch, "-U", "-u", "-j"+strconv.Itoa(runtime.NumCPU()), "kernel="+kernelName); err != nil { - return extractRootCause(err) + return err } for _, s := range []struct{ dir, src, dst string }{ {compileDir, "netbsd.gdb", "obj/netbsd.gdb"}, -- cgit mrf-deployment