diff options
| author | Dmitry Vyukov <dvyukov@google.com> | 2020-06-25 20:03:10 +0200 |
|---|---|---|
| committer | Dmitry Vyukov <dvyukov@google.com> | 2020-07-02 10:56:05 +0200 |
| commit | e8fcf811ec8e1678e173f2c0549b21f88a5ccb66 (patch) | |
| tree | c8f62a004d4f8807db632bbd017f147c0823f124 /pkg/bisect/bisect_test.go | |
| parent | 1640a9d5285f3a31cf48f6ed1972324a2ca34c41 (diff) | |
pkg/bisect: don't ignore errors during config minimization
Ignoring errors is bad. It leads to silent failures.
If there is some particular error condition that is expected
to happen and we want to ignore, we need to ignore that one only
rather than all potenital errors in the whole process.
Diffstat (limited to 'pkg/bisect/bisect_test.go')
| -rw-r--r-- | pkg/bisect/bisect_test.go | 8 |
1 files changed, 3 insertions, 5 deletions
diff --git a/pkg/bisect/bisect_test.go b/pkg/bisect/bisect_test.go index 8c8b75991..a8fc8d51d 100644 --- a/pkg/bisect/bisect_test.go +++ b/pkg/bisect/bisect_test.go @@ -205,7 +205,7 @@ var bisectionTests = []BisectionTest{ baselineConfig: "baseline-skip", }, { - name: "cause-finds-cause-minimize_succeeds", + name: "cause-finds-cause-minimize-succeeds", startCommit: 905, commitLen: 1, expectRep: true, @@ -213,12 +213,10 @@ var bisectionTests = []BisectionTest{ baselineConfig: "minimize-succeeds", }, { - name: "cause-finds-cause-minimize_fails", + name: "cause-finds-cause-minimize-fails", startCommit: 905, - commitLen: 1, - expectRep: true, - culprit: 602, baselineConfig: "minimize-fails", + expectErr: true, }, // Tests that cause bisection returns error when crash does not reproduce // on the original commit. |