From e8fcf811ec8e1678e173f2c0549b21f88a5ccb66 Mon Sep 17 00:00:00 2001 From: Dmitry Vyukov Date: Thu, 25 Jun 2020 20:03:10 +0200 Subject: pkg/bisect: don't ignore errors during config minimization Ignoring errors is bad. It leads to silent failures. If there is some particular error condition that is expected to happen and we want to ignore, we need to ignore that one only rather than all potenital errors in the whole process. --- pkg/bisect/bisect_test.go | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) (limited to 'pkg/bisect/bisect_test.go') diff --git a/pkg/bisect/bisect_test.go b/pkg/bisect/bisect_test.go index 8c8b75991..a8fc8d51d 100644 --- a/pkg/bisect/bisect_test.go +++ b/pkg/bisect/bisect_test.go @@ -205,7 +205,7 @@ var bisectionTests = []BisectionTest{ baselineConfig: "baseline-skip", }, { - name: "cause-finds-cause-minimize_succeeds", + name: "cause-finds-cause-minimize-succeeds", startCommit: 905, commitLen: 1, expectRep: true, @@ -213,12 +213,10 @@ var bisectionTests = []BisectionTest{ baselineConfig: "minimize-succeeds", }, { - name: "cause-finds-cause-minimize_fails", + name: "cause-finds-cause-minimize-fails", startCommit: 905, - commitLen: 1, - expectRep: true, - culprit: 602, baselineConfig: "minimize-fails", + expectErr: true, }, // Tests that cause bisection returns error when crash does not reproduce // on the original commit. -- cgit mrf-deployment