aboutsummaryrefslogtreecommitdiffstats
path: root/dashboard/dashapi
diff options
context:
space:
mode:
authorDmitry Vyukov <dvyukov@google.com>2019-11-06 17:59:11 +0100
committerDmitry Vyukov <dvyukov@google.com>2019-11-07 11:07:03 +0100
commit30cb7f98cd1aba45565123caf4cbd73772bb8b58 (patch)
treed43386f633ef60f4314d9d8ae2b02b0dea4af370 /dashboard/dashapi
parentf15876118387bb9e4c079f29d06394b36e393180 (diff)
pkg/bisect: detect wrong bisections
Detect bisection to merge commits and to commits that don't affect kernel binary (comments, other arches, whitespaces, etc). Such bisections are not reported in emails (but shown on web). Update #1271
Diffstat (limited to 'dashboard/dashapi')
-rw-r--r--dashboard/dashapi/dashapi.go8
1 files changed, 8 insertions, 0 deletions
diff --git a/dashboard/dashapi/dashapi.go b/dashboard/dashapi/dashapi.go
index 4b2060463..b05f3fbf5 100644
--- a/dashboard/dashapi/dashapi.go
+++ b/dashboard/dashapi/dashapi.go
@@ -158,6 +158,7 @@ type JobDoneReq struct {
// If there is 1 commits: bisection result (cause or fix).
// If there are more than 1: suspected commits due to skips (broken build/boot).
Commits []Commit
+ Flags JobDoneFlags
}
type JobType int
@@ -168,6 +169,13 @@ const (
JobBisectFix
)
+type JobDoneFlags int64
+
+const (
+ BisectResultMerge JobDoneFlags = 1 << iota // bisected to a merge commit
+ BisectResultNoop // commit does not affect resulting kernel binary
+)
+
func (dash *Dashboard) JobPoll(req *JobPollReq) (*JobPollResp, error) {
resp := new(JobPollResp)
err := dash.Query("job_poll", req, resp)