From 30cb7f98cd1aba45565123caf4cbd73772bb8b58 Mon Sep 17 00:00:00 2001 From: Dmitry Vyukov Date: Wed, 6 Nov 2019 17:59:11 +0100 Subject: pkg/bisect: detect wrong bisections Detect bisection to merge commits and to commits that don't affect kernel binary (comments, other arches, whitespaces, etc). Such bisections are not reported in emails (but shown on web). Update #1271 --- dashboard/dashapi/dashapi.go | 8 ++++++++ 1 file changed, 8 insertions(+) (limited to 'dashboard/dashapi') diff --git a/dashboard/dashapi/dashapi.go b/dashboard/dashapi/dashapi.go index 4b2060463..b05f3fbf5 100644 --- a/dashboard/dashapi/dashapi.go +++ b/dashboard/dashapi/dashapi.go @@ -158,6 +158,7 @@ type JobDoneReq struct { // If there is 1 commits: bisection result (cause or fix). // If there are more than 1: suspected commits due to skips (broken build/boot). Commits []Commit + Flags JobDoneFlags } type JobType int @@ -168,6 +169,13 @@ const ( JobBisectFix ) +type JobDoneFlags int64 + +const ( + BisectResultMerge JobDoneFlags = 1 << iota // bisected to a merge commit + BisectResultNoop // commit does not affect resulting kernel binary +) + func (dash *Dashboard) JobPoll(req *JobPollReq) (*JobPollResp, error) { resp := new(JobPollResp) err := dash.Query("job_poll", req, resp) -- cgit mrf-deployment