diff options
| author | Aleksandr Nogikh <nogikh@google.com> | 2025-03-07 16:05:31 +0100 |
|---|---|---|
| committer | Aleksandr Nogikh <nogikh@google.com> | 2025-03-08 21:58:12 +0000 |
| commit | 163f510d99dcf7239e56cef53bbca39db1f2fd9b (patch) | |
| tree | 8f246758557af38063013bebd4440ba46e2efe6e /dashboard/app/reporting.go | |
| parent | 7e3bd60dd6c8f783f5a418c64aa75f6818236dc4 (diff) | |
dashboard: include revoked reproducers in reports
Context: #5829.
Let's not pretend that the revoked reproducer never existed and still
report it. It will avoid unexpected side-effects for the higher-level
logic.
There may be better ways to resolve the bug, but let's first just get it
fixed to prevent syzbot from spamming the mailing lists.
Add a test to verify the new behavior.
Diffstat (limited to 'dashboard/app/reporting.go')
| -rw-r--r-- | dashboard/app/reporting.go | 21 |
1 files changed, 10 insertions, 11 deletions
diff --git a/dashboard/app/reporting.go b/dashboard/app/reporting.go index 9601d2718..6171ad487 100644 --- a/dashboard/app/reporting.go +++ b/dashboard/app/reporting.go @@ -570,18 +570,17 @@ func crashBugReport(c context.Context, bug *Bug, crash *Crash, crashKey *db.Key, Manager: crash.Manager, Assets: assetList, ReportElements: &dashapi.ReportElements{GuiltyFiles: crash.ReportElements.GuiltyFiles}, + ReproIsRevoked: crash.ReproIsRevoked, } - if !crash.ReproIsRevoked { - rep.ReproCLink = externalLink(c, textReproC, crash.ReproC) - rep.ReproC, _, err = getText(c, textReproC, crash.ReproC) - if err != nil { - return nil, err - } - rep.ReproSyzLink = externalLink(c, textReproSyz, crash.ReproSyz) - rep.ReproSyz, err = loadReproSyz(c, crash) - if err != nil { - return nil, err - } + rep.ReproCLink = externalLink(c, textReproC, crash.ReproC) + rep.ReproC, _, err = getText(c, textReproC, crash.ReproC) + if err != nil { + return nil, err + } + rep.ReproSyzLink = externalLink(c, textReproSyz, crash.ReproSyz) + rep.ReproSyz, err = loadReproSyz(c, crash) + if err != nil { + return nil, err } if bugReporting.CC != "" { rep.CC = append(rep.CC, strings.Split(bugReporting.CC, "|")...) |