From 163f510d99dcf7239e56cef53bbca39db1f2fd9b Mon Sep 17 00:00:00 2001
From: Aleksandr Nogikh <nogikh@google.com>
Date: Fri, 7 Mar 2025 16:05:31 +0100
Subject: dashboard: include revoked reproducers in reports

Context: #5829.

Let's not pretend that the revoked reproducer never existed and still
report it. It will avoid unexpected side-effects for the higher-level
logic.

There may be better ways to resolve the bug, but let's first just get it
fixed to prevent syzbot from spamming the mailing lists.

Add a test to verify the new behavior.
---
 dashboard/app/reporting.go | 21 ++++++++++-----------
 1 file changed, 10 insertions(+), 11 deletions(-)

(limited to 'dashboard/app/reporting.go')

diff --git a/dashboard/app/reporting.go b/dashboard/app/reporting.go
index 9601d2718..6171ad487 100644
--- a/dashboard/app/reporting.go
+++ b/dashboard/app/reporting.go
@@ -570,18 +570,17 @@ func crashBugReport(c context.Context, bug *Bug, crash *Crash, crashKey *db.Key,
 		Manager:         crash.Manager,
 		Assets:          assetList,
 		ReportElements:  &dashapi.ReportElements{GuiltyFiles: crash.ReportElements.GuiltyFiles},
+		ReproIsRevoked:  crash.ReproIsRevoked,
 	}
-	if !crash.ReproIsRevoked {
-		rep.ReproCLink = externalLink(c, textReproC, crash.ReproC)
-		rep.ReproC, _, err = getText(c, textReproC, crash.ReproC)
-		if err != nil {
-			return nil, err
-		}
-		rep.ReproSyzLink = externalLink(c, textReproSyz, crash.ReproSyz)
-		rep.ReproSyz, err = loadReproSyz(c, crash)
-		if err != nil {
-			return nil, err
-		}
+	rep.ReproCLink = externalLink(c, textReproC, crash.ReproC)
+	rep.ReproC, _, err = getText(c, textReproC, crash.ReproC)
+	if err != nil {
+		return nil, err
+	}
+	rep.ReproSyzLink = externalLink(c, textReproSyz, crash.ReproSyz)
+	rep.ReproSyz, err = loadReproSyz(c, crash)
+	if err != nil {
+		return nil, err
 	}
 	if bugReporting.CC != "" {
 		rep.CC = append(rep.CC, strings.Split(bugReporting.CC, "|")...)
-- 
cgit mrf-deployment