diff options
| author | Aleksandr Nogikh <nogikh@google.com> | 2023-11-22 14:14:07 +0100 |
|---|---|---|
| committer | Aleksandr Nogikh <nogikh@google.com> | 2023-11-22 13:37:28 +0000 |
| commit | cdd4e8035d2aa20897d97cece8607c8177e0aacd (patch) | |
| tree | 67b680803f98ce92bfc4efbb6e6633d0b88ad5f8 /dashboard/app/handler.go | |
| parent | cb976f63e0177b96eb9ce1c631cc5e2c4b4b0759 (diff) | |
dashboard: don't print error on high memcache contention
At peak load times, it can be expected that CAS will require too many
iterations. There's no reason to report it as an error.
Diffstat (limited to 'dashboard/app/handler.go')
| -rw-r--r-- | dashboard/app/handler.go | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/dashboard/app/handler.go b/dashboard/app/handler.go index 7162bd85c..ee937f1c6 100644 --- a/dashboard/app/handler.go +++ b/dashboard/app/handler.go @@ -94,7 +94,10 @@ func throttleRequest(c context.Context, w http.ResponseWriter, r *http.Request) return true } accept, err := ThrottleRequest(c, ip) - if err != nil { + if errors.Is(err, ErrThrottleTooManyRetries) { + // We get these at peak QPS anyway, it's not an error. + log.Warningf(c, "failed to throttle: %v", err) + } else if err != nil { log.Errorf(c, "failed to throttle: %v", err) } log.Infof(c, "throttling for %q: %t", ip, accept) |