From cdd4e8035d2aa20897d97cece8607c8177e0aacd Mon Sep 17 00:00:00 2001 From: Aleksandr Nogikh Date: Wed, 22 Nov 2023 14:14:07 +0100 Subject: dashboard: don't print error on high memcache contention At peak load times, it can be expected that CAS will require too many iterations. There's no reason to report it as an error. --- dashboard/app/handler.go | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) (limited to 'dashboard/app/handler.go') diff --git a/dashboard/app/handler.go b/dashboard/app/handler.go index 7162bd85c..ee937f1c6 100644 --- a/dashboard/app/handler.go +++ b/dashboard/app/handler.go @@ -94,7 +94,10 @@ func throttleRequest(c context.Context, w http.ResponseWriter, r *http.Request) return true } accept, err := ThrottleRequest(c, ip) - if err != nil { + if errors.Is(err, ErrThrottleTooManyRetries) { + // We get these at peak QPS anyway, it's not an error. + log.Warningf(c, "failed to throttle: %v", err) + } else if err != nil { log.Errorf(c, "failed to throttle: %v", err) } log.Infof(c, "throttling for %q: %t", ip, accept) -- cgit mrf-deployment