diff options
| author | Aleksandr Nogikh <nogikh@google.com> | 2025-05-23 15:14:05 +0200 |
|---|---|---|
| committer | Aleksandr Nogikh <nogikh@google.com> | 2025-05-23 16:30:38 +0000 |
| commit | ed351ea732d889c7798e7f0226bcaec65a8a6b52 (patch) | |
| tree | e51f8b2b90895a249c276231d302cdfa7b695d09 | |
| parent | f8cc0c832b122cdf7a643d6965200c9cbb0a92a4 (diff) | |
syz-cluster: fix db-mgmt job problems
Don't restart the job if it returned a non-zero exit code.
Don't treat the ErrNoChange error as a failure.
| -rw-r--r-- | syz-cluster/db-mgmt/migrate-job.yaml | 1 | ||||
| -rw-r--r-- | syz-cluster/pkg/db/spanner.go | 7 |
2 files changed, 7 insertions, 1 deletions
diff --git a/syz-cluster/db-mgmt/migrate-job.yaml b/syz-cluster/db-mgmt/migrate-job.yaml index 4a9cb36ba..30e29385c 100644 --- a/syz-cluster/db-mgmt/migrate-job.yaml +++ b/syz-cluster/db-mgmt/migrate-job.yaml @@ -7,6 +7,7 @@ metadata: generateName: db-migrate-job- spec: ttlSecondsAfterFinished: 86400 + backoffLimit: 0 template: spec: serviceAccountName: gke-db-admin-ksa diff --git a/syz-cluster/pkg/db/spanner.go b/syz-cluster/pkg/db/spanner.go index 3135038b3..9bdeee53b 100644 --- a/syz-cluster/pkg/db/spanner.go +++ b/syz-cluster/pkg/db/spanner.go @@ -109,7 +109,12 @@ func RunMigrations(uri string) error { if err != nil { return err } - return m.Up() + err = m.Up() + if err == migrate.ErrNoChange { + // Not really an error. + return nil + } + return err } func getMigrateInstance(uri string) (*migrate.Migrate, error) { |