From ed351ea732d889c7798e7f0226bcaec65a8a6b52 Mon Sep 17 00:00:00 2001 From: Aleksandr Nogikh Date: Fri, 23 May 2025 15:14:05 +0200 Subject: syz-cluster: fix db-mgmt job problems Don't restart the job if it returned a non-zero exit code. Don't treat the ErrNoChange error as a failure. --- syz-cluster/db-mgmt/migrate-job.yaml | 1 + syz-cluster/pkg/db/spanner.go | 7 ++++++- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/syz-cluster/db-mgmt/migrate-job.yaml b/syz-cluster/db-mgmt/migrate-job.yaml index 4a9cb36ba..30e29385c 100644 --- a/syz-cluster/db-mgmt/migrate-job.yaml +++ b/syz-cluster/db-mgmt/migrate-job.yaml @@ -7,6 +7,7 @@ metadata: generateName: db-migrate-job- spec: ttlSecondsAfterFinished: 86400 + backoffLimit: 0 template: spec: serviceAccountName: gke-db-admin-ksa diff --git a/syz-cluster/pkg/db/spanner.go b/syz-cluster/pkg/db/spanner.go index 3135038b3..9bdeee53b 100644 --- a/syz-cluster/pkg/db/spanner.go +++ b/syz-cluster/pkg/db/spanner.go @@ -109,7 +109,12 @@ func RunMigrations(uri string) error { if err != nil { return err } - return m.Up() + err = m.Up() + if err == migrate.ErrNoChange { + // Not really an error. + return nil + } + return err } func getMigrateInstance(uri string) (*migrate.Migrate, error) { -- cgit mrf-deployment