diff options
| author | Dmitry Vyukov <dvyukov@google.com> | 2018-07-10 10:19:48 +0200 |
|---|---|---|
| committer | Dmitry Vyukov <dvyukov@google.com> | 2018-07-10 10:19:48 +0200 |
| commit | 9fa03fa5c970be1fb41fe26cb2041ff4870ea7f0 (patch) | |
| tree | 464419c5c892c84e8e78cc2b6a3362dd7e056887 | |
| parent | 40ed7e838ad29ec97a110db15aaab69b350756b0 (diff) | |
syz-ci: don't put dynamic data into boot/test errors
We append underlying error to the title of boot/test errors.
The error can come from anywhere and can contain dynamic data,
which can cause duplication of bugs.
Put the underlying error into report body instead.
| -rw-r--r-- | syz-ci/manager.go | 7 |
1 files changed, 3 insertions, 4 deletions
diff --git a/syz-ci/manager.go b/syz-ci/manager.go index b5a41f2ae..05396ce81 100644 --- a/syz-ci/manager.go +++ b/syz-ci/manager.go @@ -371,12 +371,11 @@ func (mgr *Manager) testImage(imageDir string, info *BuildInfo) error { switch err := res.(type) { case *instance.TestError: if rep := err.Report; rep != nil { + rep.Report = append([]byte(rep.Title), rep.Report...) if err.Boot { - rep.Title = fmt.Sprintf("%v boot error: %v", - mgr.mgrcfg.RepoAlias, rep.Title) + rep.Title = fmt.Sprintf("%v boot error", mgr.mgrcfg.RepoAlias) } else { - rep.Title = fmt.Sprintf("%v test error: %v", - mgr.mgrcfg.RepoAlias, rep.Title) + rep.Title = fmt.Sprintf("%v test error", mgr.mgrcfg.RepoAlias) } if err := mgr.reportBuildError(rep, info, imageDir); err != nil { mgr.Errorf("failed to report image error: %v", err) |