From 9fa03fa5c970be1fb41fe26cb2041ff4870ea7f0 Mon Sep 17 00:00:00 2001 From: Dmitry Vyukov Date: Tue, 10 Jul 2018 10:19:48 +0200 Subject: syz-ci: don't put dynamic data into boot/test errors We append underlying error to the title of boot/test errors. The error can come from anywhere and can contain dynamic data, which can cause duplication of bugs. Put the underlying error into report body instead. --- syz-ci/manager.go | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/syz-ci/manager.go b/syz-ci/manager.go index b5a41f2ae..05396ce81 100644 --- a/syz-ci/manager.go +++ b/syz-ci/manager.go @@ -371,12 +371,11 @@ func (mgr *Manager) testImage(imageDir string, info *BuildInfo) error { switch err := res.(type) { case *instance.TestError: if rep := err.Report; rep != nil { + rep.Report = append([]byte(rep.Title), rep.Report...) if err.Boot { - rep.Title = fmt.Sprintf("%v boot error: %v", - mgr.mgrcfg.RepoAlias, rep.Title) + rep.Title = fmt.Sprintf("%v boot error", mgr.mgrcfg.RepoAlias) } else { - rep.Title = fmt.Sprintf("%v test error: %v", - mgr.mgrcfg.RepoAlias, rep.Title) + rep.Title = fmt.Sprintf("%v test error", mgr.mgrcfg.RepoAlias) } if err := mgr.reportBuildError(rep, info, imageDir); err != nil { mgr.Errorf("failed to report image error: %v", err) -- cgit mrf-deployment