diff options
| author | Dmitry Vyukov <dvyukov@google.com> | 2020-03-27 07:17:29 +0100 |
|---|---|---|
| committer | Dmitry Vyukov <dvyukov@google.com> | 2020-03-27 10:43:05 +0100 |
| commit | 9b6ecd9356e9e5bdb086000ceeda06f680aed22d (patch) | |
| tree | 82480d93b537aa50be6ecaf49cc558ca78ba737a | |
| parent | 9af8b4b30b7381d85e62ddaa51b98caeb01da7ee (diff) | |
dashboard/app: fix tests hang
This is ugly but without this go test hangs with:
panic: Metadata fetch failed for 'instance/attributes/gae_backend_version':
Get http://metadata/computeMetadata/v1/instance/attributes/gae_backend_version:
dial tcp: lookup metadata on 127.0.0.1:53: no such host
It's unclear what's the proper fix for this.
It used to work for me for ridiculous reasons only:
somebody provided metadata host which returned errors,
but since nobody cares what's in the returned response
and no error checking whatsoever, it somehow did not crash...
| -rw-r--r-- | dashboard/app/app_test.go | 9 |
1 files changed, 9 insertions, 0 deletions
diff --git a/dashboard/app/app_test.go b/dashboard/app/app_test.go index 6ece0cee5..ce27b92d3 100644 --- a/dashboard/app/app_test.go +++ b/dashboard/app/app_test.go @@ -6,6 +6,7 @@ package main import ( "fmt" "net/http" + "os" "strconv" "strings" "testing" @@ -16,6 +17,14 @@ import ( ) func init() { + // This is ugly but without this go test hangs with: + // panic: Metadata fetch failed for 'instance/attributes/gae_backend_version': + // Get http://metadata/computeMetadata/v1/instance/attributes/gae_backend_version: + // dial tcp: lookup metadata on 127.0.0.1:53: no such host + // It's unclear what's the proper fix for this. + os.Setenv("GAE_MODULE_VERSION", "1") + os.Setenv("GAE_MINOR_VERSION", "1") + isBrokenAuthDomainInTest = true obsoleteWhatWontBeFixBisected = true notifyAboutUnsuccessfulBisections = true |