From 9b6ecd9356e9e5bdb086000ceeda06f680aed22d Mon Sep 17 00:00:00 2001 From: Dmitry Vyukov Date: Fri, 27 Mar 2020 07:17:29 +0100 Subject: dashboard/app: fix tests hang This is ugly but without this go test hangs with: panic: Metadata fetch failed for 'instance/attributes/gae_backend_version': Get http://metadata/computeMetadata/v1/instance/attributes/gae_backend_version: dial tcp: lookup metadata on 127.0.0.1:53: no such host It's unclear what's the proper fix for this. It used to work for me for ridiculous reasons only: somebody provided metadata host which returned errors, but since nobody cares what's in the returned response and no error checking whatsoever, it somehow did not crash... --- dashboard/app/app_test.go | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/dashboard/app/app_test.go b/dashboard/app/app_test.go index 6ece0cee5..ce27b92d3 100644 --- a/dashboard/app/app_test.go +++ b/dashboard/app/app_test.go @@ -6,6 +6,7 @@ package main import ( "fmt" "net/http" + "os" "strconv" "strings" "testing" @@ -16,6 +17,14 @@ import ( ) func init() { + // This is ugly but without this go test hangs with: + // panic: Metadata fetch failed for 'instance/attributes/gae_backend_version': + // Get http://metadata/computeMetadata/v1/instance/attributes/gae_backend_version: + // dial tcp: lookup metadata on 127.0.0.1:53: no such host + // It's unclear what's the proper fix for this. + os.Setenv("GAE_MODULE_VERSION", "1") + os.Setenv("GAE_MINOR_VERSION", "1") + isBrokenAuthDomainInTest = true obsoleteWhatWontBeFixBisected = true notifyAboutUnsuccessfulBisections = true -- cgit mrf-deployment