aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDmitry Vyukov <dvyukov@google.com>2019-01-23 10:19:14 +0100
committerDmitry Vyukov <dvyukov@google.com>2019-01-23 10:19:27 +0100
commit9a689e2d3deb71d7d5b9686cc56ea4a6a4f4b9e6 (patch)
tree2f43c7f3d4d3df595e606ae04cbc217a5051d846
parent7cf3249cff77008dbd822f4e3ba981011eadddc9 (diff)
syz-ci: extend logging in uploadBuildError
-rw-r--r--syz-ci/syzupdater.go7
1 files changed, 5 insertions, 2 deletions
diff --git a/syz-ci/syzupdater.go b/syz-ci/syzupdater.go
index 66c8812a1..66d910725 100644
--- a/syz-ci/syzupdater.go
+++ b/syz-ci/syzupdater.go
@@ -280,6 +280,7 @@ func (upd *SyzUpdater) uploadBuildError(commit *vcs.Commit, buildErr error) {
// as it is not associated with any namespace.
// So we use the first manager client for this.
if upd.dashboardAddr == "" || upd.mgrcfg.DashboardClient == "" {
+ log.Logf(0, "not uploading build error: no dashboard")
return
}
dash := dashapi.New(upd.dashboardAddr, upd.mgrcfg.DashboardClient, upd.mgrcfg.DashboardKey)
@@ -313,8 +314,10 @@ func (upd *SyzUpdater) uploadBuildError(commit *vcs.Commit, buildErr error) {
Log: output,
},
}
- // TODO: log ReportBuildError error to dashboard.
- dash.ReportBuildError(req)
+ if err := dash.ReportBuildError(req); err != nil {
+ // TODO: log ReportBuildError error to dashboard.
+ log.Logf(0, "failed to report build error: %v", err)
+ }
}
// checkLatest returns tag of the latest build,