From 9a689e2d3deb71d7d5b9686cc56ea4a6a4f4b9e6 Mon Sep 17 00:00:00 2001 From: Dmitry Vyukov Date: Wed, 23 Jan 2019 10:19:14 +0100 Subject: syz-ci: extend logging in uploadBuildError --- syz-ci/syzupdater.go | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/syz-ci/syzupdater.go b/syz-ci/syzupdater.go index 66c8812a1..66d910725 100644 --- a/syz-ci/syzupdater.go +++ b/syz-ci/syzupdater.go @@ -280,6 +280,7 @@ func (upd *SyzUpdater) uploadBuildError(commit *vcs.Commit, buildErr error) { // as it is not associated with any namespace. // So we use the first manager client for this. if upd.dashboardAddr == "" || upd.mgrcfg.DashboardClient == "" { + log.Logf(0, "not uploading build error: no dashboard") return } dash := dashapi.New(upd.dashboardAddr, upd.mgrcfg.DashboardClient, upd.mgrcfg.DashboardKey) @@ -313,8 +314,10 @@ func (upd *SyzUpdater) uploadBuildError(commit *vcs.Commit, buildErr error) { Log: output, }, } - // TODO: log ReportBuildError error to dashboard. - dash.ReportBuildError(req) + if err := dash.ReportBuildError(req); err != nil { + // TODO: log ReportBuildError error to dashboard. + log.Logf(0, "failed to report build error: %v", err) + } } // checkLatest returns tag of the latest build, -- cgit mrf-deployment