diff options
| author | Dmitry Vyukov <dvyukov@google.com> | 2016-02-18 21:48:45 +0100 |
|---|---|---|
| committer | Dmitry Vyukov <dvyukov@google.com> | 2016-02-18 21:48:45 +0100 |
| commit | 862594f1b6b764f3149d90fcd8a83ddad6b7ee20 (patch) | |
| tree | 2affbcd28ce2a9443875386ee7b5ebb2463be5c2 | |
| parent | 8e0d5c2bd01651bfa775f3cf3df9823e8a8faa31 (diff) | |
manager: don't confuse users with zero coverage
| -rw-r--r-- | syz-manager/cover.go | 9 | ||||
| -rw-r--r-- | syz-manager/html.go | 2 |
2 files changed, 5 insertions, 6 deletions
diff --git a/syz-manager/cover.go b/syz-manager/cover.go index efeb14795..c55f75264 100644 --- a/syz-manager/cover.go +++ b/syz-manager/cover.go @@ -24,16 +24,15 @@ type LineInfo struct { } func generateCoverHtml(w io.Writer, vmlinux string, cov []uint32) error { + if len(cov) == 0 { + return fmt.Errorf("No coverage data available") + } info, prefix, err := symbolize(vmlinux, cov) if err != nil { return err } if len(info) == 0 { - if len(cov) == 0 { - return fmt.Errorf("No coverage data available") - } else { - return fmt.Errorf("'%s' does not have debug info (set CONFIG_DEBUG_INFO=y)", vmlinux) - } + return fmt.Errorf("'%s' does not have debug info (set CONFIG_DEBUG_INFO=y)", vmlinux) } var d templateData diff --git a/syz-manager/html.go b/syz-manager/html.go index 56f2c5537..5b74911f1 100644 --- a/syz-manager/html.go +++ b/syz-manager/html.go @@ -223,7 +223,7 @@ Uptime: {{.Uptime}}<br> Corpus: {{.CorpusSize}}<br> Triage queue len: {{.TriageQueue}}<br> Cover mem: {{.CorpusCoverMem}} + {{.CallCoverMem}} <br> -<a href='/cover'>Cover: {{.CoverSize}}</a> <br> +{{if .CoverSize}}<a href='/cover'>Cover: {{.CoverSize}}</a> <br>{{end}} <br> Stats: <br> {{range $stat := $.Stats}} |