From 862594f1b6b764f3149d90fcd8a83ddad6b7ee20 Mon Sep 17 00:00:00 2001
From: Dmitry Vyukov <dvyukov@google.com>
Date: Thu, 18 Feb 2016 21:48:45 +0100
Subject: manager: don't confuse users with zero coverage

---
 syz-manager/cover.go | 9 ++++-----
 syz-manager/html.go  | 2 +-
 2 files changed, 5 insertions(+), 6 deletions(-)

diff --git a/syz-manager/cover.go b/syz-manager/cover.go
index efeb14795..c55f75264 100644
--- a/syz-manager/cover.go
+++ b/syz-manager/cover.go
@@ -24,16 +24,15 @@ type LineInfo struct {
 }
 
 func generateCoverHtml(w io.Writer, vmlinux string, cov []uint32) error {
+	if len(cov) == 0 {
+		return fmt.Errorf("No coverage data available")
+	}
 	info, prefix, err := symbolize(vmlinux, cov)
 	if err != nil {
 		return err
 	}
 	if len(info) == 0 {
-		if len(cov) == 0 {
-			return fmt.Errorf("No coverage data available")
-		} else {
-			return fmt.Errorf("'%s' does not have debug info (set CONFIG_DEBUG_INFO=y)", vmlinux)
-		}
+		return fmt.Errorf("'%s' does not have debug info (set CONFIG_DEBUG_INFO=y)", vmlinux)
 	}
 
 	var d templateData
diff --git a/syz-manager/html.go b/syz-manager/html.go
index 56f2c5537..5b74911f1 100644
--- a/syz-manager/html.go
+++ b/syz-manager/html.go
@@ -223,7 +223,7 @@ Uptime: {{.Uptime}}<br>
 Corpus: {{.CorpusSize}}<br>
 Triage queue len: {{.TriageQueue}}<br>
 Cover mem: {{.CorpusCoverMem}} + {{.CallCoverMem}} <br>
-<a href='/cover'>Cover: {{.CoverSize}}</a> <br>
+{{if .CoverSize}}<a href='/cover'>Cover: {{.CoverSize}}</a> <br>{{end}}
 <br>
 Stats: <br>
 {{range $stat := $.Stats}}
-- 
cgit mrf-deployment