aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDmitry Vyukov <dvyukov@google.com>2020-01-29 16:15:37 +0100
committerDmitry Vyukov <dvyukov@google.com>2020-01-29 16:15:37 +0100
commit5ed23f9aa677d71bc60f61df8e05046151868541 (patch)
tree86a7ca03bfb4bedde6a83576f5b09b5caca96fa8
parent0c6a2c332895b02ab904a2f66f6b6feb4c2ee22a (diff)
dashboard/app: skip tests if dev_appserver.py is missing
Travis is not the right check. We also don't have dev_appserver.py anywhere on syzbot, so builds fail. Check presence of dev_appserver.py explicitly.
-rw-r--r--dashboard/app/util_test.go6
1 files changed, 3 insertions, 3 deletions
diff --git a/dashboard/app/util_test.go b/dashboard/app/util_test.go
index dcae8ace6..d7ac5970a 100644
--- a/dashboard/app/util_test.go
+++ b/dashboard/app/util_test.go
@@ -12,7 +12,7 @@ import (
"io/ioutil"
"net/http"
"net/http/httptest"
- "os"
+ "os/exec"
"path/filepath"
"reflect"
"runtime"
@@ -42,8 +42,8 @@ type Ctx struct {
}
func NewCtx(t *testing.T) *Ctx {
- if os.Getenv("TRAVIS") != "" {
- t.Skip("skipping test on Travis (no dev_appserver.py)")
+ if _, err := exec.LookPath("dev_appserver.py"); err != nil {
+ t.Skip("skipping test (no dev_appserver.py)")
}
t.Parallel()
inst, err := aetest.NewInstance(&aetest.Options{