From 5ed23f9aa677d71bc60f61df8e05046151868541 Mon Sep 17 00:00:00 2001 From: Dmitry Vyukov Date: Wed, 29 Jan 2020 16:15:37 +0100 Subject: dashboard/app: skip tests if dev_appserver.py is missing Travis is not the right check. We also don't have dev_appserver.py anywhere on syzbot, so builds fail. Check presence of dev_appserver.py explicitly. --- dashboard/app/util_test.go | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/dashboard/app/util_test.go b/dashboard/app/util_test.go index dcae8ace6..d7ac5970a 100644 --- a/dashboard/app/util_test.go +++ b/dashboard/app/util_test.go @@ -12,7 +12,7 @@ import ( "io/ioutil" "net/http" "net/http/httptest" - "os" + "os/exec" "path/filepath" "reflect" "runtime" @@ -42,8 +42,8 @@ type Ctx struct { } func NewCtx(t *testing.T) *Ctx { - if os.Getenv("TRAVIS") != "" { - t.Skip("skipping test on Travis (no dev_appserver.py)") + if _, err := exec.LookPath("dev_appserver.py"); err != nil { + t.Skip("skipping test (no dev_appserver.py)") } t.Parallel() inst, err := aetest.NewInstance(&aetest.Options{ -- cgit mrf-deployment