diff options
| author | Taras Madan <tarasmadan@google.com> | 2025-03-28 17:19:12 +0100 |
|---|---|---|
| committer | Taras Madan <tarasmadan@google.com> | 2025-03-28 17:37:06 +0000 |
| commit | 32665a357cbde5e6bdc7e92c325127d9d5a9b463 (patch) | |
| tree | 6d885d0cec8e5fdde4f1630b69e2240c46b44cda | |
| parent | b00ef8dc5f5b6b79828da7b726ee6d3dd02b9ad5 (diff) | |
pkg/covermerger: skip record without target line
Some records have only information about the function covered. Let's skip them.
~2% of the records in BigQuery don't have information about line.
It is a side effect of #5850.
| -rw-r--r-- | pkg/covermerger/file_line_merger.go | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/pkg/covermerger/file_line_merger.go b/pkg/covermerger/file_line_merger.go index 817099a60..8a54bfa22 100644 --- a/pkg/covermerger/file_line_merger.go +++ b/pkg/covermerger/file_line_merger.go @@ -42,6 +42,11 @@ type FileLineCoverMerger struct { } func (a *FileLineCoverMerger) Add(record *FileRecord) { + if record.StartLine < 0 { + // This record doesn't have information about line coverage. + // The best we sometimes have is the function name. + return + } if a.matchers[record.RepoCommit] == nil { if record.HitCount > 0 { a.lostFrames[record.RepoCommit]++ |