From 32665a357cbde5e6bdc7e92c325127d9d5a9b463 Mon Sep 17 00:00:00 2001 From: Taras Madan Date: Fri, 28 Mar 2025 17:19:12 +0100 Subject: pkg/covermerger: skip record without target line Some records have only information about the function covered. Let's skip them. ~2% of the records in BigQuery don't have information about line. It is a side effect of #5850. --- pkg/covermerger/file_line_merger.go | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/pkg/covermerger/file_line_merger.go b/pkg/covermerger/file_line_merger.go index 817099a60..8a54bfa22 100644 --- a/pkg/covermerger/file_line_merger.go +++ b/pkg/covermerger/file_line_merger.go @@ -42,6 +42,11 @@ type FileLineCoverMerger struct { } func (a *FileLineCoverMerger) Add(record *FileRecord) { + if record.StartLine < 0 { + // This record doesn't have information about line coverage. + // The best we sometimes have is the function name. + return + } if a.matchers[record.RepoCommit] == nil { if record.HitCount > 0 { a.lostFrames[record.RepoCommit]++ -- cgit mrf-deployment