diff options
| author | Aleksandr Nogikh <nogikh@google.com> | 2022-08-11 18:21:25 +0000 |
|---|---|---|
| committer | Aleksandr Nogikh <wp32pw@gmail.com> | 2022-08-26 12:33:44 +0200 |
| commit | 2f3b44ea4305aa200432fef587ba1a6dc89a00f3 (patch) | |
| tree | 0d9ab5ea33fd6f16c608a0c754b2bbd0c8c31a3d | |
| parent | ae7ef8be831892da91b059337920c5db86941580 (diff) | |
dashboard: visualize stale repros
When rendering a crash list, strike stale repros with a line (like the
<s></s> tag does).
| -rw-r--r-- | dashboard/app/main.go | 2 | ||||
| -rw-r--r-- | dashboard/app/templates.html | 5 | ||||
| -rw-r--r-- | pkg/html/pages/style.css | 4 |
3 files changed, 9 insertions, 2 deletions
diff --git a/dashboard/app/main.go b/dashboard/app/main.go index 32288b8d5..8a2a63cf4 100644 --- a/dashboard/app/main.go +++ b/dashboard/app/main.go @@ -193,6 +193,7 @@ type uiCrash struct { ReportLink string ReproSyzLink string ReproCLink string + ReproIsRevoked bool MachineInfoLink string *uiBuild } @@ -1056,6 +1057,7 @@ func makeUICrash(crash *Crash, build *Build) *uiCrash { ReportLink: textLink(textCrashReport, crash.Report), ReproSyzLink: textLink(textReproSyz, crash.ReproSyz), ReproCLink: textLink(textReproC, crash.ReproC), + ReproIsRevoked: crash.ReproIsRevoked, MachineInfoLink: textLink(textMachineInfo, crash.MachineInfo), } if build != nil { diff --git a/dashboard/app/templates.html b/dashboard/app/templates.html index bc3ae3ded..a9fc80727 100644 --- a/dashboard/app/templates.html +++ b/dashboard/app/templates.html @@ -350,14 +350,15 @@ Use of this source code is governed by Apache 2 LICENSE that can be found in the <td class="config">{{if $b.KernelConfigLink}}<a href="{{$b.KernelConfigLink}}">.config</a>{{end}}</td> <td class="repro">{{if $b.LogLink}}<a href="{{$b.LogLink}}">log</a>{{end}}</td> <td class="repro">{{if $b.ReportLink}}<a href="{{$b.ReportLink}}">report</a>{{end}}</td> - <td class="repro">{{if $b.ReproSyzLink}}<a href="{{$b.ReproSyzLink}}">syz</a>{{end}}</td> - <td class="repro">{{if $b.ReproCLink}}<a href="{{$b.ReproCLink}}">C</a>{{end}}</td> + <td class="repro{{if $b.ReproIsRevoked}} stale_repro{{end}}">{{if $b.ReproSyzLink}}<a href="{{$b.ReproSyzLink}}">syz</a>{{end}}</td> + <td class="repro {{if $b.ReproIsRevoked}} stale_repro{{end}}">{{if $b.ReproCLink}}<a href="{{$b.ReproCLink}}">C</a>{{end}}</td> <td class="repro">{{if $b.MachineInfoLink}}<a href="{{$b.MachineInfoLink}}">info</a>{{end}}</td> <td class="manager">{{$b.Title}}</td> </tr> {{end}} </tbody> </table> +<i>* <s>Struck through</s> repros no longer work on HEAD.</i> {{end}} {{end}} diff --git a/pkg/html/pages/style.css b/pkg/html/pages/style.css index 7a2ca851a..19d06210b 100644 --- a/pkg/html/pages/style.css +++ b/pkg/html/pages/style.css @@ -181,6 +181,10 @@ table td, table th { font-family: monospace; } +.list_table .stale_repro { + text-decoration: line-through; +} + .bad { color: #f00; font-weight: bold; |