From 2f3b44ea4305aa200432fef587ba1a6dc89a00f3 Mon Sep 17 00:00:00 2001 From: Aleksandr Nogikh Date: Thu, 11 Aug 2022 18:21:25 +0000 Subject: dashboard: visualize stale repros When rendering a crash list, strike stale repros with a line (like the tag does). --- dashboard/app/main.go | 2 ++ dashboard/app/templates.html | 5 +++-- pkg/html/pages/style.css | 4 ++++ 3 files changed, 9 insertions(+), 2 deletions(-) diff --git a/dashboard/app/main.go b/dashboard/app/main.go index 32288b8d5..8a2a63cf4 100644 --- a/dashboard/app/main.go +++ b/dashboard/app/main.go @@ -193,6 +193,7 @@ type uiCrash struct { ReportLink string ReproSyzLink string ReproCLink string + ReproIsRevoked bool MachineInfoLink string *uiBuild } @@ -1056,6 +1057,7 @@ func makeUICrash(crash *Crash, build *Build) *uiCrash { ReportLink: textLink(textCrashReport, crash.Report), ReproSyzLink: textLink(textReproSyz, crash.ReproSyz), ReproCLink: textLink(textReproC, crash.ReproC), + ReproIsRevoked: crash.ReproIsRevoked, MachineInfoLink: textLink(textMachineInfo, crash.MachineInfo), } if build != nil { diff --git a/dashboard/app/templates.html b/dashboard/app/templates.html index bc3ae3ded..a9fc80727 100644 --- a/dashboard/app/templates.html +++ b/dashboard/app/templates.html @@ -350,14 +350,15 @@ Use of this source code is governed by Apache 2 LICENSE that can be found in the {{if $b.KernelConfigLink}}.config{{end}} {{if $b.LogLink}}log{{end}} {{if $b.ReportLink}}report{{end}} - {{if $b.ReproSyzLink}}syz{{end}} - {{if $b.ReproCLink}}C{{end}} + {{if $b.ReproSyzLink}}syz{{end}} + {{if $b.ReproCLink}}C{{end}} {{if $b.MachineInfoLink}}info{{end}} {{$b.Title}} {{end}} +* Struck through repros no longer work on HEAD. {{end}} {{end}} diff --git a/pkg/html/pages/style.css b/pkg/html/pages/style.css index 7a2ca851a..19d06210b 100644 --- a/pkg/html/pages/style.css +++ b/pkg/html/pages/style.css @@ -181,6 +181,10 @@ table td, table th { font-family: monospace; } +.list_table .stale_repro { + text-decoration: line-through; +} + .bad { color: #f00; font-weight: bold; -- cgit mrf-deployment