aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDmitry Vyukov <dvyukov@google.com>2024-04-26 12:49:05 +0200
committerDmitry Vyukov <dvyukov@google.com>2024-04-26 11:42:18 +0000
commit2a444fae4fd848ad3bd2c0a3eb13fdad8280fd30 (patch)
tree3a6f4ce7eb04261c85d0af3348d0c6849ca15298
parent968cb91346aa85e5ddbc7080d80cfe84975329f5 (diff)
dashboard/app: fix bad use of context values
Linter warns: dashboard/app/util_test.go:680:47: SA1029: should not use built-in type string as key for value; define your own type to avoid collisions newContext := context.WithValue(r.Context(), requestIDKey, requestNum) ^
-rw-r--r--dashboard/app/util_test.go6
1 files changed, 3 insertions, 3 deletions
diff --git a/dashboard/app/util_test.go b/dashboard/app/util_test.go
index 66663cb3c..ff74187a9 100644
--- a/dashboard/app/util_test.go
+++ b/dashboard/app/util_test.go
@@ -677,7 +677,7 @@ func registerRequest(r *http.Request, c *Ctx) *http.Request {
defer requestMu.Unlock()
requestNum++
- newContext := context.WithValue(r.Context(), requestIDKey, requestNum)
+ newContext := context.WithValue(r.Context(), requestIDKey{}, requestNum)
newRequest := r.WithContext(newContext)
requestContexts = append(requestContexts, RequestMapping{requestNum, c})
return newRequest
@@ -709,10 +709,10 @@ func unregisterContext(c *Ctx) {
requestContexts = requestContexts[:n]
}
-const requestIDKey = "test_request_id"
+type requestIDKey struct{}
func getRequestID(c context.Context) int {
- val, ok := c.Value(requestIDKey).(int)
+ val, ok := c.Value(requestIDKey{}).(int)
if !ok {
panic("the context did not come from a test")
}