From 2a444fae4fd848ad3bd2c0a3eb13fdad8280fd30 Mon Sep 17 00:00:00 2001 From: Dmitry Vyukov Date: Fri, 26 Apr 2024 12:49:05 +0200 Subject: dashboard/app: fix bad use of context values Linter warns: dashboard/app/util_test.go:680:47: SA1029: should not use built-in type string as key for value; define your own type to avoid collisions newContext := context.WithValue(r.Context(), requestIDKey, requestNum) ^ --- dashboard/app/util_test.go | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/dashboard/app/util_test.go b/dashboard/app/util_test.go index 66663cb3c..ff74187a9 100644 --- a/dashboard/app/util_test.go +++ b/dashboard/app/util_test.go @@ -677,7 +677,7 @@ func registerRequest(r *http.Request, c *Ctx) *http.Request { defer requestMu.Unlock() requestNum++ - newContext := context.WithValue(r.Context(), requestIDKey, requestNum) + newContext := context.WithValue(r.Context(), requestIDKey{}, requestNum) newRequest := r.WithContext(newContext) requestContexts = append(requestContexts, RequestMapping{requestNum, c}) return newRequest @@ -709,10 +709,10 @@ func unregisterContext(c *Ctx) { requestContexts = requestContexts[:n] } -const requestIDKey = "test_request_id" +type requestIDKey struct{} func getRequestID(c context.Context) int { - val, ok := c.Value(requestIDKey).(int) + val, ok := c.Value(requestIDKey{}).(int) if !ok { panic("the context did not come from a test") } -- cgit mrf-deployment