1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
|
// Copyright 2015 syzkaller project authors. All rights reserved.
// Use of this source code is governed by Apache 2 LICENSE that can be found in the LICENSE file.
// Package vm provides an abstract test machine (VM, physical machine, etc)
// interface for the rest of the system.
// For convenience test machines are subsequently collectively called VMs.
// Package wraps vmimpl package interface with some common functionality
// and higher-level interface.
package vm
import (
"bytes"
"context"
"errors"
"fmt"
"io"
"os"
"path/filepath"
"strings"
"sync/atomic"
"time"
"github.com/google/syzkaller/pkg/log"
"github.com/google/syzkaller/pkg/mgrconfig"
"github.com/google/syzkaller/pkg/osutil"
"github.com/google/syzkaller/pkg/report"
"github.com/google/syzkaller/pkg/stat"
"github.com/google/syzkaller/sys/targets"
"github.com/google/syzkaller/vm/dispatcher"
"github.com/google/syzkaller/vm/vmimpl"
// Import all VM implementations, so that users only need to import vm.
_ "github.com/google/syzkaller/vm/adb"
_ "github.com/google/syzkaller/vm/bhyve"
_ "github.com/google/syzkaller/vm/cuttlefish"
_ "github.com/google/syzkaller/vm/gce"
_ "github.com/google/syzkaller/vm/gvisor"
_ "github.com/google/syzkaller/vm/isolated"
_ "github.com/google/syzkaller/vm/proxyapp"
_ "github.com/google/syzkaller/vm/qemu"
_ "github.com/google/syzkaller/vm/starnix"
_ "github.com/google/syzkaller/vm/vmm"
_ "github.com/google/syzkaller/vm/vmware"
)
type Pool struct {
impl vmimpl.Pool
typ vmimpl.Type
workdir string
template string
timeouts targets.Timeouts
count int
activeCount int32
snapshot bool
hostFuzzer bool
statOutputReceived *stat.Val
}
type Instance struct {
pool *Pool
impl vmimpl.Instance
workdir string
index int
snapshotSetup bool
onClose func()
}
var (
Shutdown = vmimpl.Shutdown
ErrTimeout = vmimpl.ErrTimeout
_ BootErrorer = vmimpl.BootError{}
_ InfraErrorer = vmimpl.InfraError{}
)
func ShutdownCtx() context.Context {
ctx, done := context.WithCancel(context.Background())
go func() {
<-Shutdown
done()
}()
return ctx
}
type BootErrorer interface {
BootError() (string, []byte)
}
type InfraErrorer interface {
InfraError() (string, []byte)
}
// vmType splits the VM type from any suffix (separated by ":"). This is mostly
// useful for the "proxyapp" type, where pkg/build needs to specify/handle
// sub-types.
func vmType(fullName string) string {
name, _, _ := strings.Cut(fullName, ":")
return name
}
// AllowsOvercommit returns if the instance type allows overcommit of instances
// (i.e. creation of instances out-of-thin-air). Overcommit is used during image
// and patch testing in syz-ci when it just asks for more than specified in config
// instances. Generally virtual machines (qemu, gce) support overcommit,
// while physical machines (adb, isolated) do not. Strictly speaking, we should
// never use overcommit and use only what's specified in config, because we
// override resource limits specified in config (e.g. can OOM). But it works and
// makes lots of things much simpler.
func AllowsOvercommit(typ string) bool {
return vmimpl.Types[vmType(typ)].Overcommit
}
// Create creates a VM pool that can be used to create individual VMs.
func Create(cfg *mgrconfig.Config, debug bool) (*Pool, error) {
typ, ok := vmimpl.Types[vmType(cfg.Type)]
if !ok {
return nil, fmt.Errorf("unknown instance type '%v'", cfg.Type)
}
env := &vmimpl.Env{
Name: cfg.Name,
OS: cfg.TargetOS,
Arch: cfg.TargetVMArch,
Workdir: cfg.Workdir,
Image: cfg.Image,
SSHKey: cfg.SSHKey,
SSHUser: cfg.SSHUser,
Timeouts: cfg.Timeouts,
Snapshot: cfg.Snapshot,
Debug: debug,
Config: cfg.VM,
KernelSrc: cfg.KernelSrc,
}
impl, err := typ.Ctor(env)
if err != nil {
return nil, err
}
count := impl.Count()
if debug && count > 1 {
log.Logf(0, "limiting number of VMs from %v to 1 in debug mode", count)
count = 1
}
return &Pool{
impl: impl,
typ: typ,
workdir: env.Workdir,
template: cfg.WorkdirTemplate,
timeouts: cfg.Timeouts,
count: count,
snapshot: cfg.Snapshot,
hostFuzzer: cfg.SysTarget.HostFuzzer,
statOutputReceived: stat.New("vm output", "Bytes of VM console output received",
stat.Graph("traffic"), stat.Rate{}, stat.FormatMB),
}, nil
}
func (pool *Pool) Count() int {
return pool.count
}
func (pool *Pool) Create(index int) (*Instance, error) {
if index < 0 || index >= pool.count {
return nil, fmt.Errorf("invalid VM index %v (count %v)", index, pool.count)
}
workdir, err := osutil.ProcessTempDir(pool.workdir)
if err != nil {
return nil, fmt.Errorf("failed to create instance temp dir: %w", err)
}
if pool.template != "" {
if err := osutil.CopyDirRecursively(pool.template, filepath.Join(workdir, "template")); err != nil {
return nil, err
}
}
impl, err := pool.impl.Create(workdir, index)
if err != nil {
os.RemoveAll(workdir)
return nil, err
}
atomic.AddInt32(&pool.activeCount, 1)
return &Instance{
pool: pool,
impl: impl,
workdir: workdir,
index: index,
onClose: func() { atomic.AddInt32(&pool.activeCount, -1) },
}, nil
}
// TODO: Integration or end-to-end testing is needed.
//
// https://github.com/google/syzkaller/pull/3269#discussion_r967650801
func (pool *Pool) Close() error {
if pool.activeCount != 0 {
panic("all the instances should be closed before pool.Close()")
}
if closer, ok := pool.impl.(io.Closer); ok {
return closer.Close()
}
return nil
}
// SetupSnapshot must be called once before calling RunSnapshot.
// Input is copied into the VM in an implementation defined way and is interpreted by executor.
func (inst *Instance) SetupSnapshot(input []byte) error {
impl, ok := inst.impl.(snapshotter)
if !ok {
return errors.New("this VM type does not support snapshot mode")
}
if inst.snapshotSetup {
return fmt.Errorf("SetupSnapshot called twice")
}
inst.snapshotSetup = true
return impl.SetupSnapshot(input)
}
// RunSnapshot runs one input in snapshotting mode.
// Input is copied into the VM in an implementation defined way and is interpreted by executor.
// Result is the result provided by the executor.
// Output is the kernel console output during execution of the input.
func (inst *Instance) RunSnapshot(input []byte) (result, output []byte, err error) {
impl, ok := inst.impl.(snapshotter)
if !ok {
return nil, nil, errors.New("this VM type does not support snapshot mode")
}
if !inst.snapshotSetup {
return nil, nil, fmt.Errorf("RunSnapshot without SetupSnapshot")
}
// Executor has own timeout logic, so use a slightly larger timeout here.
timeout := inst.pool.timeouts.Program / 5 * 7
return impl.RunSnapshot(timeout, input)
}
type snapshotter interface {
SetupSnapshot([]byte) error
RunSnapshot(time.Duration, []byte) ([]byte, []byte, error)
}
func (inst *Instance) Copy(hostSrc string) (string, error) {
return inst.impl.Copy(hostSrc)
}
func (inst *Instance) Forward(port int) (string, error) {
return inst.impl.Forward(port)
}
type ExitCondition int
const (
// The program is allowed to exit after timeout.
ExitTimeout = ExitCondition(1 << iota)
// The program is allowed to exit with no errors.
ExitNormal
// The program is allowed to exit with errors.
ExitError
)
type StopContext context.Context
type InjectExecuting <-chan bool
type OutputSize int
// An early notification that the command has finished / VM crashed.
type EarlyFinishCb func()
// Run runs cmd inside of the VM (think of ssh cmd) and monitors command execution
// and the kernel console output. It detects kernel oopses in output, lost connections, hangs, etc.
// Returns command+kernel output and a non-symbolized crash report (nil if no error happens).
// Accepted options:
// - StopContext: the context to be used to prematurely stop the command
// - ExitCondition: says which exit modes should be considered as errors/OK
// - OutputSize: how much output to keep/return
func (inst *Instance) Run(timeout time.Duration, reporter *report.Reporter, command string, opts ...any) (
[]byte, *report.Report, error) {
exit := ExitNormal
var stop <-chan bool
var injected <-chan bool
var finished func()
outputSize := beforeContextDefault
for _, o := range opts {
switch opt := o.(type) {
case ExitCondition:
exit = opt
case StopContext:
stopCh := make(chan bool)
go func() {
<-opt.Done()
close(stopCh)
}()
stop = stopCh
case OutputSize:
outputSize = int(opt)
case InjectExecuting:
injected = (<-chan bool)(opt)
case EarlyFinishCb:
finished = opt
default:
panic(fmt.Sprintf("unknown option %#v", opt))
}
}
outc, errc, err := inst.impl.Run(timeout, stop, command)
if err != nil {
return nil, nil, err
}
mon := &monitor{
inst: inst,
outc: outc,
injected: injected,
errc: errc,
finished: finished,
reporter: reporter,
beforeContext: outputSize,
exit: exit,
lastExecuteTime: time.Now(),
}
rep := mon.monitorExecution()
return mon.output, rep, nil
}
func (inst *Instance) Info() ([]byte, error) {
if ii, ok := inst.impl.(vmimpl.Infoer); ok {
return ii.Info()
}
return nil, nil
}
func (inst *Instance) diagnose(rep *report.Report) ([]byte, bool) {
if rep == nil {
panic("rep is nil")
}
return inst.impl.Diagnose(rep)
}
func (inst *Instance) Index() int {
return inst.index
}
func (inst *Instance) Close() error {
err := inst.impl.Close()
if retErr := os.RemoveAll(inst.workdir); err == nil {
err = retErr
}
inst.onClose()
return err
}
type Dispatcher = dispatcher.Pool[*Instance]
func NewDispatcher(pool *Pool, def dispatcher.Runner[*Instance]) *Dispatcher {
return dispatcher.NewPool(pool.count, pool.Create, def)
}
type monitor struct {
inst *Instance
outc <-chan []byte
injected <-chan bool
finished func()
errc <-chan error
reporter *report.Reporter
exit ExitCondition
output []byte
beforeContext int
matchPos int
lastExecuteTime time.Time
extractCalled bool
}
func (mon *monitor) monitorExecution() *report.Report {
ticker := time.NewTicker(tickerPeriod * mon.inst.pool.timeouts.Scale)
defer ticker.Stop()
defer func() {
if mon.finished != nil {
mon.finished()
}
}()
for {
select {
case err := <-mon.errc:
switch err {
case nil:
// The program has exited without errors,
// but wait for kernel output in case there is some delayed oops.
crash := ""
if mon.exit&ExitNormal == 0 {
crash = lostConnectionCrash
}
return mon.extractError(crash)
case ErrTimeout:
if mon.exit&ExitTimeout == 0 {
return mon.extractError(timeoutCrash)
}
return nil
default:
// Note: connection lost can race with a kernel oops message.
// In such case we want to return the kernel oops.
crash := ""
if mon.exit&ExitError == 0 {
crash = lostConnectionCrash
}
return mon.extractError(crash)
}
case out, ok := <-mon.outc:
if !ok {
mon.outc = nil
continue
}
mon.inst.pool.statOutputReceived.Add(len(out))
if rep, done := mon.appendOutput(out); done {
return rep
}
case <-mon.injected:
mon.lastExecuteTime = time.Now()
case <-ticker.C:
// Detect both "no output whatsoever" and "kernel episodically prints
// something to console, but fuzzer is not actually executing programs".
if time.Since(mon.lastExecuteTime) > mon.inst.pool.timeouts.NoOutput {
return mon.extractError(noOutputCrash)
}
case <-Shutdown:
return nil
}
}
}
func (mon *monitor) appendOutput(out []byte) (*report.Report, bool) {
lastPos := len(mon.output)
mon.output = append(mon.output, out...)
if bytes.Contains(mon.output[lastPos:], executingProgram) {
mon.lastExecuteTime = time.Now()
}
if mon.reporter.ContainsCrash(mon.output[mon.matchPos:]) {
return mon.extractError("unknown error"), true
}
if len(mon.output) > 2*mon.beforeContext {
copy(mon.output, mon.output[len(mon.output)-mon.beforeContext:])
mon.output = mon.output[:mon.beforeContext]
}
// Find the starting position for crash matching on the next iteration.
// We step back from the end of output by maxErrorLength to handle the case
// when a crash line is currently split/incomplete. And then we try to find
// the preceding '\n' to have a full line. This is required to handle
// the case when a particular pattern is ignored as crash, but a suffix
// of the pattern is detected as crash (e.g. "ODEBUG:" is trimmed to "BUG:").
mon.matchPos = len(mon.output) - maxErrorLength
for i := 0; i < maxErrorLength; i++ {
if mon.matchPos <= 0 || mon.output[mon.matchPos-1] == '\n' {
break
}
mon.matchPos--
}
if mon.matchPos < 0 {
mon.matchPos = 0
}
return nil, false
}
func (mon *monitor) extractError(defaultError string) *report.Report {
if mon.extractCalled {
panic("extractError called twice")
}
mon.extractCalled = true
if mon.finished != nil {
// If the caller wanted an early notification, provide it.
mon.finished()
mon.finished = nil
}
diagOutput, diagWait := []byte{}, false
if defaultError != "" {
diagOutput, diagWait = mon.inst.diagnose(mon.createReport(defaultError))
}
// Give it some time to finish writing the error message.
// But don't wait for "no output", we already waited enough.
if defaultError != noOutputCrash || diagWait {
mon.waitForOutput()
}
// Check the executorPreemptedStr only for preemptible instances since executor can print
// the string spuriously in some cases (gets SIGTERM from test program somehow).
if mon.inst.pool.typ.Preemptible && bytes.Contains(mon.output, []byte(executorPreemptedStr)) {
return nil
}
if defaultError == "" && mon.reporter.ContainsCrash(mon.output[mon.matchPos:]) {
// We did not call Diagnose above because we thought there is no error, so call it now.
diagOutput, diagWait = mon.inst.diagnose(mon.createReport(defaultError))
if diagWait {
mon.waitForOutput()
}
}
rep := mon.createReport(defaultError)
if rep == nil {
return nil
}
if len(diagOutput) > 0 {
rep.Output = append(rep.Output, vmDiagnosisStart...)
rep.Output = append(rep.Output, diagOutput...)
}
return rep
}
func (mon *monitor) createReport(defaultError string) *report.Report {
rep := mon.reporter.ParseFrom(mon.output, mon.matchPos)
if rep == nil {
if defaultError == "" {
return nil
}
return &report.Report{
Title: defaultError,
Output: mon.output,
Suppressed: report.IsSuppressed(mon.reporter, mon.output),
}
}
start := rep.StartPos - mon.beforeContext
if start < 0 {
start = 0
}
end := rep.EndPos + afterContext
if end > len(rep.Output) {
end = len(rep.Output)
}
rep.Output = rep.Output[start:end]
rep.StartPos -= start
rep.EndPos -= start
return rep
}
func (mon *monitor) waitForOutput() {
timer := time.NewTimer(vmimpl.WaitForOutputTimeout * mon.inst.pool.timeouts.Scale)
defer timer.Stop()
for {
select {
case out, ok := <-mon.outc:
if !ok {
return
}
mon.output = append(mon.output, out...)
case <-timer.C:
return
case <-Shutdown:
return
}
}
}
const (
maxErrorLength = 256
lostConnectionCrash = "lost connection to test machine"
noOutputCrash = "no output from test machine"
timeoutCrash = "timed out"
executorPreemptedStr = "SYZ-EXECUTOR: PREEMPTED"
vmDiagnosisStart = "\nVM DIAGNOSIS:\n"
)
var (
executingProgram = []byte("executed programs:") // syz-execprog output
beforeContextDefault = 128 << 10
afterContext = 128 << 10
tickerPeriod = 10 * time.Second
)
|